Repository navigation
chore: fix README usage example - #29
Open
iAmMichaelConnor wants to merge 1 commit into
Open
iAmMichaelConnor wants to merge 1 commit into
iAmMichaelConnor wants to merge 1 commit into
Conversation
iAmMichaelConnor
changed the title
iAmMichaelConnor
force-pushed
the
mike/06-docs-readme-usage
branch
from
November 2, 2026 18:16
7d4ccbf to
f6ee7cf
Compare
The example used Field indices (the API takes u32), an undefined variable, a misspelled `set` and a missing semicolon.
TomAFrench
force-pushed
the
mike/06-docs-readme-usage
branch
from
November 3, 2026 03:53
f6ee7cf to
0bd6df8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The README usage example did not compile: it used
Fieldindices (the API takesu32), anundefined
nonzero_indicesin the mutable example,array.ser, and was missing a semicolon.Fix those, with otherwise the same example.
Testing
The example functions were compiled in a consumer crate against this branch with Noir 1.0.0;
the immutable example passes, and the mutable example's final
setfails with"MutSparseArray::set exceeded maximum size of array", as its comment says.