Repository navigation
Adding External Clocking example in NI-SCOPE - #2237
Merged
ni-jfitzger merged 11 commits intoNov 6, 2026
Merged
ni-jfitzger merged 11 commits into
ni-jfitzger merged 11 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2237 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 88 88
Lines 22830 22830
=======================================
+ Hits 20118 20119 +1
+ Misses 2712 2711 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
divakar-selvam07
approved these changes
Oct 29, 2026
Contributor
Author
|
Testing was limited to simulation because the hardware (NI-Scope 5164 on the test PC) does not have a clock signal connected to its input. The measurement code relies on this clock signal to execute, so hardware validation could not be performed. |
NI-velmurugan
changed the title
Contributor
Author
|
@jarnoldNI, the PR is ready for your review. |
jarnoldNI
approved these changes
Nov 2, 2026
NI-velmurugan
marked this pull request as ready for review
November 3, 2026 12:09
NI-velmurugan
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
November 3, 2026 12:09
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
ni-jfitzger
reviewed
Nov 5, 2026
ni-jfitzger
reviewed
Nov 5, 2026
ni-jfitzger
reviewed
Nov 5, 2026
ni-jfitzger
reviewed
Nov 5, 2026
ni-jfitzger
reviewed
Nov 5, 2026
ni-jfitzger
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR adds
niscope_external_clocking.py, a Python adaptation of the LabVIEWniScope EX External Clocking.viWhat testing has been done?
Manually tested the example using simulated hardware