Repository navigation
[stable35] fix(share): allow viewing files in shares with download disabled - #9586
Open
backportbot[bot] wants to merge 4 commits into
Open
backportbot[bot] wants to merge 4 commits into
backportbot[bot] wants to merge 4 commits into
Conversation
backportbot
Bot
added
bug
mejo-
force-pushed
the
backport/9581/stable35
branch
from
November 10, 2026 15:22
7873ab2 to
3fd5d58
Compare
mejo-
marked this pull request as ready for review
November 10, 2026 15:23
mejo-
approved these changes
Nov 10, 2026
Text refused to open files from shares with the download permission disabled, including the folder description (Readme.md) of shared folders and attachments in such files. Use `IShare::canSeeContent()` to decide whether Text may show a file and its attachments. Copying a file into the attachment folder still requires the download permission, as WebDAV COPY and MOVE do on the server. Migrate the share e2e tests from Cypress to Playwright and test both values of the admin setting. Fixes: #7023 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
…scription Only return the content of the folder description in the rich workspace PROPFIND properties if `canSeeContent()` allows viewing the Readme.md, as the editor already does. Otherwise the folder description preview showed content that the editor then refused to open. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
Files opened through a link share are resolved via the share owner's storage, so checking the file's storage never found the share. Check the link share itself when building the file context, and recognize any shared storage, including the one used by public WebDAV. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
backport/9581/stable35
branch
from
November 10, 2026 15:40
3fd5d58 to
6a3dc40
Compare
Member
|
/backport! to stable34 |
3 tasks done
On stable35 the viewer dialog of a public single file share has no accessible name, as the opened file is the share root `/`. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9581
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.