Repository navigation
refactor: use public server API instead of private classes - #9585
Merged
Merged
Conversation
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
mejo-
force-pushed
the
refactor/public_server_api
branch
from
November 10, 2026 16:33
9ded75c to
f04932c
Compare
blizzz
approved these changes
Nov 10, 2026
Replace OC\User\NoUserException with OCP\User\Exceptions\UserNotFoundException. The private exception extends the public one since server 35, and IRootFolder::getUserFolder() documents the public one, so the catch blocks behave the same. Replace OC\Files\Node\File with OCP\Files\File in WorkspacePlugin. The private class was only needed for getFileInfo(); the public node exposes getId() and getEtag() directly. Drop the now unused NoUserException psalm stub. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
refactor/public_server_api
branch
from
November 10, 2026 17:07
f04932c to
66a63e1
Compare
mejo-
enabled auto-merge
November 10, 2026 17:12
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace OC\User\NoUserException with
OCP\User\Exceptions\UserNotFoundException. The private exception extends the public one since server 35, and IRootFolder::getUserFolder() documents the public one, so the catch blocks behave the same.
Replace OC\Files\Node\File with OCP\Files\File in WorkspacePlugin. The private class was only needed for getFileInfo(); the public node exposes getId() and getEtag() directly.
Drop the now unused NoUserException psalm stub.
Assisted-by: ClaudeCode:claude-opus-5-5
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)