Repository navigation
fix(generate-all): report invalid --path values instead of crashing - #703
Open
horacioespinosa wants to merge 1 commit into
Open
horacioespinosa wants to merge 1 commit into
horacioespinosa wants to merge 1 commit into
Conversation
Folder::getRelativePath() returns null for a path that is not inside the user files folder, and Folder::get() throws for a missing path; neither was handled, so the command ended in a TypeError or an uncaught NotFoundException. Print an error, keep processing the other paths and exit with a non-zero code. Signed-off-by: Horacio Darinel Espinosa Barcelo <admin@cloudfrog.com.mx>
horacioespinosa
marked this pull request as ready for review
November 17, 2026 16:10
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you give
preview:generate-alla wrong--path, the command crashes with an unhandled exception, and any--pathvalues after it never get processed. It happens in two cases:--path=/alice(the missing/files/in PathHelper error when trying to generate for a specific folder #455), ends in aTypeErrorfromPathHelper::normalizePath().Folder::getRelativePath()returnsnullfor it, and that goes straight intoFolder::get().--path=/alice/files/nope, throwsNotFoundException.get()sits outside thetrythat was meant to catch it, so the existingPath not foundmessage is never printed.With this change both cases print an error (
Path /alice is not inside the files folder of user alice,Path not found: /alice/files/nope), the command goes on with the remaining--pathvalues and exits with 1. Valid paths behave as before.To unit test the command, the two
\OC_Util::tearDownFS()/\OC_Util::setupFS()pairs move into aprotectedmethod,setupUserFileSystem(), that the test overrides. That part doesn't change behaviour.