Repository navigation
Conversation
Small joint-space moves were reported as arrived before the arm left its start pose: q_tol=0.03 rad is larger than the whole displacement (a 3 mm move is about 0.008 rad), so the first still frames at the start satisfied the criterion. On hardware move_pose returned at 0.154 s while motion started at 0.18 s and settled at 0.94 s. When the commanded displacement is between 5 mrad and 0.12 rad, _arrive now tightens the tolerance to max(5 mrad, delta/4), requires half of the displacement to be covered, and requires 200 ms of continuous stillness to cover the firmware hold handoff. movej, movej_sync and home pass the pre-command q as start; large moves keep the previous behavior exactly. Real-arm retest (Litearm1.11.1-7J): a 10 mm step now returns after 0.70 s with 0.74 mm error, instead of returning early and measuring 4.97 mm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Arm._arrivecould report a small joint-space move as arrived before the arm left its start pose. The nominalq_tol=0.03 radis larger than the whole displacement of a 3 mm move (about 0.008 rad), so the first still frames at the start already satisfied the arrival criterion. On hardware (7J LiteArm, firmwareLitearm1.11.1-7J) a 3 mmmove_posereturned at 0.154 s while the motion started at 0.18 s and settled at 0.94 s; a caller could send the next command to an arm that was still moving.Changes
_arrivenow accepts the pre-commandqasstart. Displacements between 5 mrad and 0.12 rad are treated as small moves: the tolerance is tightened tomax(5 mrad, delta/4), at least half of the displacement must be covered, and 200 ms of continuous stillness is required (covering the firmware hold handoff). Large moves, and calls withoutstart, keep the previous behavior exactly.movej,movej_syncandhomecapture the pre-command state and pass it through.tests/test_arrive_small_move.py: a pacedFakeTransportpushes 10 status frames at the start pose and then the target frames. It fails on the old code (returns the start q) and passes with the change.Testing
main(AssertionError: 0.0 != 0.008 within 6 places) and passes with the patch.Litearm1.11.1-7J, speed 0.1), guarded 2/5/10 mm moves:5ce0cbf) and passed the full suite (42 passed, 1 skipped) plus the real-arm checks.Issues
Related to #48 (found during its real-arm review). No separate issue was opened.