Repository navigation
feat: expose joint_follow, the joint impedance channel - #13
Merged
Merged
Conversation
The firmware has had CMD_JOINT_FOLLOW (0x08) for some time and this SDK had no entry for it. It was registered in preexisting_gaps() rather than in firmware_only_cmds(), and the note there says what that registration means: not "deliberately not exposed" but "not done yet", with a standing instruction that the entry is not a resting place - either add it or rule that the absence is intentional. This adds it. Arm::joint_follow(q, dq, kp, kd) sends q + dq + kp + kd, 16N bytes, and no tau: the feedforward is the firmware's, computed every tick from gravity and the joint limit wall, and the frame carries only the stiffnesses. The gap table is empty again and the coverage table has the command. What the command is for, and what it costs, is on the declaration: it enters a session in which the safety envelope's overspeed and position rules are waived, so the host is the only bound. That is the point of it - it is the channel for real time following without the rate limiting the other paths apply - and it is also the thing to know before reaching for it. Three tables had to agree and each is asserted: the coverage table, the gaps table, and the coverage harness, whose two sentinels refuse a command no test sends and a public entry that is not registered.
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The firmware has had
CMD_JOINT_FOLLOW(0x08) for some time and this SDK had no entry forit. It sat in
preexisting_gaps(), and the note there says what that registration means:not "deliberately not exposed" but "not done yet". This adds the entry.
Changes
Arm::joint_follow(q, dq, kp, kd)sends 16N bytes and notau: the feedforward (gravity,the joint limit wall) stays the firmware's business, computed every tick from the
stiffnesses in the frame.
preexisting_gaps()into the coverage table. Three tables have toagree and each is asserted: the coverage table, the gaps table, and the coverage harness,
whose two sentinels refuse a command no test sends and a public entry that is not registered.
envelope's overspeed and position rules are waived, so the host becomes the only bound on
the arm.
Testing
Consumers:
nexform-tech/litearm-ros2-control's joint_follow path needs this entry, and itsCI checks litearm-cpp out at its default branch. Its PR therefore stays red until this one
merges.