Repository navigation
fix: renew_ip keeps the default route - #79
Open
shubham-kaushal wants to merge 1 commit into
Open
shubham-kaushal wants to merge 1 commit into
shubham-kaushal wants to merge 1 commit into
Conversation
Removing the old address drops the default route, so renew_ip adds it again.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renew_ipremoves the old address, and the default route through that address goes with it. After a renewal, the device has no default route.renew_ipnow adds the default route again when the renewed interface carries it. The new testrenew_ip_keeps_default_routefails onmainand passes with this change.