Skip to content

fix: preserve learned patterns and Rust module analysis - #54

Merged
mstuart merged 1 commit into
mainfrom
maintenance/2026-11-02-analysis
Nov 2, 2026
Merged

mstuart merged 1 commit into
mainfrom
maintenance/2026-11-02-analysis

Conversation

@mstuart

@mstuart mstuart commented Nov 2, 2026

Copy link
Copy Markdown
Owner

Fix three independently reproduced analysis defects:

  • Match decision categories and migration FROM/TO keywords case-insensitively while preserving technology spelling.
  • Make plain PatternLibrary observations visible to pattern queries, confidence thresholds and counts, including mixed example/plain observations.
  • Resolve Rust child modules in both foo.rs and foo/mod.rs layouts, including child/mod.rs targets and either file discovery order.

All three public-API regressions failed on the original source. The full cargo test harness passes (122 completed cases, one pre-existing ignored model-download test); six PostgreSQL cases return early locally without TEST_DATABASE_URL and will use CI's configured PostgreSQL service. Clippy with warnings denied and formatting pass, including after the independent Rustls lockfile update. No dependency, release, infrastructure or database-schema changes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T03:22:31.121965Z 4da22d9 PR opened
🔒 Security Review ✅ Completed 2026-11-02T03:23:59.068539Z 4da22d9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mstuart
mstuart merged commit d6b0154 into main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant