Repository navigation
Conversation
…y_size` as configuration options These were already exposed on glean-core (and UDL) and thus all the other languages.
…body_size` as configurable options
…he recoverable failures maximum
badboy
force-pushed
the
different-http-error-codes-are/pumwmutyolxv
branch
from
November 13, 2026 12:15
eb79265 to
a47afaa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already had
max_pending_pings_countandmax_pending_pings_directory_sizeexposed, so I decided to add the other 3 policy options as well.It would probably be nicer if we bundle that up and expose the
Policyobject instead, but that is more work; this was a mostly mechanical change to apply it to all target languages.This also then sets
max_recoverable_failureshigh sodifferent_http_error_codes_are_handleddoesn't run into the problem.Breaking change (due to the new options exposed on
Configuration) -- but we soon have one pending anyway.