Repository navigation
Conversation
The manifests and tasks selected for the modified paths were found in the working directory, which is not updated to the pushed revisions as it is too slow, so new tests and manifests were missed. Read the files at the head of the push with Mercurial instead: the files of a revision are computed from the ones of the previous revision and the files changed between the two, and only the changed test manifests are parsed again. The manifests at tip are parsed when booting the worker, before it forks for each job. Fixes mozilla#5854
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5854.
find_manifests_for_pathsandfind_tasks_for_pathsused the files in the working directory, which the HTTP service doesn't update to the pushed revisions anymore (462d916), so tests and manifests added by a push were missed.Instead of updating the working directory, they now take the revision and read the files at that revision with Mercurial:
hg files -r REV. The files of later revisions are computed from the ones of the previous revision andhg status --rev PREV --rev REV, and only the test manifests changed in between are read (hg cat -T json) and parsed again.Tested on a mozilla-central clone: the selected manifests and tasks were identical to the ones found in an updated working directory for 350 sampled paths. On my (slow, WSL) machine, booting took ~16-19s and a job on a revision 300 commits after the boot one ~7-10s, nearly all spent in
hg status/hg cat.In the tests, the files are committed and the working directory is emptied before each call, to check that nothing is read from it.