Skip to content

Ads-Client: Adds batched 'store ads' insertion to AdsStore - #7776

Merged
thesuzerain merged 1 commit into
mainfrom
Ads-client-ads-store-uses-multi-insert
Nov 13, 2026
Merged

thesuzerain merged 1 commit into
mainfrom
Ads-client-ads-store-uses-multi-insert

Conversation

@thesuzerain

@thesuzerain thesuzerain commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a multi-insert option to AdsStore.

We use a transaction and a prepared statement to significantly boost past the naive repeated-connection insertions.

This also renames a lot of store_ad to store_ads- the store_ad seemed quite misleading (especially as we add an alternate batch function). It is actually storing multiple ads for one placement id.

AdStore only- no breaking changes.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@thesuzerain
thesuzerain marked this pull request as ready for review November 13, 2026 18:01
@thesuzerain
thesuzerain requested a review from a team as a code owner November 13, 2026 18:01
@thesuzerain
thesuzerain added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 5f95eb6 Nov 13, 2026
15 checks passed
@thesuzerain
thesuzerain deleted the Ads-client-ads-store-uses-multi-insert branch November 13, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants