[Miodec]

Roadmap step U5: tags, presets and custom themes get the one-getter read pattern.

Summary

Each collection module owns a module-level live query and exports plain getters. They are reactive in components and effects, synchronous everywhere else, never suspend, and return only what's loaded.

 collections/tags.ts            (same shape: presets.ts, custom-themes.ts)
-  useTagsLiveQuery()           # suspending hook, components only
-  useActiveTagsLiveQuery()
-  __nonReactive.getTags()      # escape hatch for plain code
+  createSessionDownload(...)   # this sign-in's download: loading | loaded | failed
+  tagsQuery = createRoot(() => useLiveQuery(... only once status is "loaded"))
+  getTags() / getTag(id) / getActiveTags()   # read tagsQuery.state, never tagsQuery()
+  getTagsStatus()
 collections/utils/
+  session-download.ts

• Single-row getters are fine-grained. getTag(id) reruns only when that row changes.
• Loading state uses a status, not Suspense. The settings custom themes list switches on getCustomThemesStatus(): a loading circle, the list, or "Failed to load custom themes" with a Retry button (reloadCustomThemes()).
• Callers moved to the getters:
  • commandline tag, preset and custom theme lists (they still rebuild on open);
  • the custom-themes check in config metadata;
  • the theme and preset controllers and the preset modals;
  • the settings, account, result and test-notice components;
  • results.ts.
• __nonReactive is removed from presets and custom themes. Tags keep it for test-logic and result-pb, which move in T6a/T6c.

Fixed along the way

A collection's rows outlive sign-out: the ["user"] query reset doesn't clear them. On the next sign-in the previous session's rows showed as loaded, and the blocking wait for tags and presets returned straight away with them.

 on sign in
-  collection still "ready" with the previous session's rows
+  createSessionDownload: status "loading", start the download
+  getters return nothing, waitForTagsReady/waitForPresetsReady hold
+  query succeeds → "loaded" (rows already written) | fails → "failed" (the wait still returns)

Evidence

• Before: sign in as A, sign out, sign in as B → getTags() immediately returns A's tags, reported as loaded.
  After: tags.spec "drops the previous user's tags on sign out" passes (fails on the first commit). The same holds for custom themes.
• Before: a failed custom themes download → the settings list shows the loading circle forever.
  After: "reports a failed download, and loads on reload" passes. In the browser (failure forced): the error and Retry show, and Retry brings in the 20 themes.
• Getter specs for all three collections cover:
  • sorted rows;
  • a synchronous read right after a write;
  • effects rerunning, but only for their own row;
  • empty and "loading" while signed out;
  • no GC after 10 minutes.
• Full suite: 1772 passed, and lint is clean. One earlier run had an app-shell routing test fail once; it passed on its own and in later full runs.
• Browser:
  • The commandline tag, preset and custom theme lists show.
  • Toggling a tag updates the notice above the test.
  • The settings lists refill after signing out and back in.
  • Each sign-in fetches users, custom themes and presets once each, with no duplicates.
  • The console stays clean.

Merge Danger

Door: two-way

Frontend-only refactor and fixes: no API, storage or schema changes.

Blast Radius: moderate

These three collections are read from many places: the commandline, settings, account, the result screen, the test notice, the theme controller and the preset controller. Possible problems:

• the custom themes list could show a loading state where it used to be briefly empty;
• sign-in now waits for this session's tags and presets download, not just the first one.

Spec updated in this PR: Server data, Intended deviations ("From user data (U5)") and Q28.

🤖 Generated with Claude Code

[Copilot]

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🟡 Changes recommended

Open review findings indicate unresolved state-handling and performance issues, including missing load-status checks that can bypass the theme limit and a render-time inefficiency from repeated tag sorting.

3 open issues

• Use custom theme load status for shift-click guard · New
• Block saving custom themes until loading finishes · New
• Memoize active tags instead of sorting three times · New

What changed in this PR

Refactors the tags, presets, and custom themes collections to a non-suspending “plain getter” read pattern backed by a module-level reactive mirror, with per-session download status to avoid leaking previous-session rows across sign-in/out.

Changes:

• Add session-scoped download/status tracking for user collections (loading/loaded/failed) with reload support.
• Replace use*LiveQuery()/most __nonReactive reads with synchronous getters (get*, get*Status) across UI, controllers, and commandline.
• Update collections, components, and tests to validate new getter semantics, session isolation, and failure/retry behavior.

File	Description
frontend/​src/​ts/​queries/​index.ts	Updates query/reset documentation and wiring to support session-gated collection reads after sign-in/out.
frontend/​src/​ts/​db.ts	Removes now-unneeded imports/usages tied to the prior non-reactive tags access pattern.
frontend/​src/​ts/​controllers/​theme-controller.ts	Switches theme selection logic to read custom themes via the new getter-based APIs.
frontend/​src/​ts/​controllers/​preset-controller.ts	Refactors preset lookup/application to use getPreset() rather than legacy non-reactive access.
frontend/​src/​ts/​config/​metadata.tsx	Updates config metadata validation to use custom theme getters for random/custom theme constraints.
frontend/​src/​ts/​components/​pages/​test/​result/​ResultSecondaryStats.tsx	Replaces tags live-query reads with synchronous tag getters when rendering secondary stats.
frontend/​src/​ts/​components/​pages/​test/​result/​ResultChart.tsx	Updates chart tag labeling to use getTag() without suspending component rendering.
frontend/​src/​ts/​components/​pages/​test/​modes-notice/​TestModesNotice.tsx	Migrates active-tag rendering logic from live-query hooks to getActiveTags().
frontend/​src/​ts/​components/​pages/​settings/​custom-setting/​Theme.tsx	Reworks custom theme settings UI to use status-driven loading/failed/loaded states with retry and getter reads.
frontend/​src/​ts/​components/​pages/​settings/​custom-setting/​Tags.tsx	Moves settings tags list to the new tags getters instead of suspending live queries.
frontend/​src/​ts/​components/​pages/​settings/​custom-setting/​Presets.tsx	Moves settings presets list to the new presets getters instead of suspending live queries.
frontend/​src/​ts/​components/​pages/​account/​Table.tsx	Refactors account table tag usage to read from tag getters.
frontend/​src/​ts/​components/​pages/​account/​Filters.tsx	Updates account filters to source tag data from synchronous getters.
frontend/​src/​ts/​components/​pages/​account/​Charts.tsx	Updates account charts/filter summaries to use tag getters.
frontend/​src/​ts/​components/​modals/​preset/​preset-modal-utils.ts	Updates preset modal utilities to read active tags through the getter API.
frontend/​src/​ts/​components/​modals/​preset/​EditPresetModal.tsx	Migrates the preset edit modal to fetch the edited preset via getPreset().
frontend/​src/​ts/​components/​modals/​EditResultTagsModal.tsx	Updates the result tag editor modal to list and resolve tags via getTags().
frontend/​src/​ts/​components/​layout/​footer/​ThemeIndicator.tsx	Switches the footer theme indicator to use custom theme getters for availability checks.
frontend/​src/​ts/​commandline/​lists/​tags.ts	Refactors commandline tag list generation to use tag getters instead of non-reactive reads.
frontend/​src/​ts/​commandline/​lists/​presets.ts	Refactors commandline preset list generation to use presets getters instead of non-reactive reads.
frontend/​src/​ts/​commandline/​lists/​custom-themes-list.ts	Refactors commandline custom theme list generation to use custom theme getters instead of non-reactive reads.
frontend/​src/​ts/​collections/​utils/​session-download.ts	Introduces a reusable helper to track per-session download lifecycle and expose status/reload/wait semantics.
frontend/​src/​ts/​collections/​tags.ts	Implements session-gated tags live-query mirroring with synchronous getters (including single-row access).
frontend/​src/​ts/​collections/​results.ts	Updates results collection logic to use active-tag getters where tag data is needed for queries/filters.
frontend/​src/​ts/​collections/​presets.ts	Implements session-gated presets mirroring with synchronous getters and removes the prior non-reactive escape hatch.
frontend/​src/​ts/​collections/​custom-themes.ts	Implements session-gated custom themes mirroring with synchronous getters, status exposure, and explicit reload support.
frontend/​src/​ts/​auth.tsx	Adjusts sign-in flow expectations to align with per-session tags/presets download readiness semantics.
frontend/​__tests__/​controllers/​preset-controller.spec.ts	Updates controller tests to mock/spy on the new getter-based preset access pattern.
frontend/​__tests__/​components/​pages/​test/​result/​ResultChart.spec.tsx	Updates chart tests to reflect getter-based tag lookup without Suspense-driven behavior.
frontend/​__tests__/​collections/​tags.spec.ts	Adds coverage for tags getter semantics, session isolation across sign-out, and status transitions.
frontend/​__tests__/​collections/​presets.spec.ts	Adds coverage for presets getter semantics, synchronous reads after writes, and session isolation behavior.
frontend/​__tests__/​collections/​custom-themes.spec.ts	Adds coverage for custom themes status, failure/retry behavior, and hiding prior-session rows until loaded.
docs/​specs/​solid-monkeytype/​roadmap.md	Marks roadmap step U5 as complete and documents the getter-based collection read approach.

_{Review effort: Balanced}