Repository navigation
Omit tracing metadata outside recording spans - #425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #396.
JSON logs emitted outside a recording OpenTelemetry span now omit the empty
tracingobject. Logs inside a recording span includespan_idandtrace_id. The processor stays registered so spans created outside lite-bootstrap can supply trace context.Breaking changes
Log parsers must treat
tracingas optional. The 2.x migration guide documents the change.Verification
The rendered JSON regression failed before the fix and passed afterward.
just lint-ci,just test-ci(636 tests, 100% coverage), andjust docs-buildpassed. Standards and spec reviews found no implementation issues. The optional processor optimization was not benchmarked.