[aceforeverd]

modelsphere/modelsphere#57

[huskcass]

No blockers. CI is green apart from publish, which is still pending. Checked at f211264.

Medium

• Overdesign in swiss/lib/resources.ts. useResourceRows mirrors draft rows into local state and keeps them in sync with value using lastEmittedRef, prevBaseKeysRef and an effect that reseeds or filters the drafts. That is a lot of machinery for a small table. Hold the custom rows in the form as an ordered array and derive the edits from it when planning. That removes the refs and the effect, and replaceCustomResources, customResourceRows and clearResourceOverride mostly go with them.
• Speculative extras that can be cut: the COMMON_RESOURCE_KEYS dropdown plus SWISS_RESOURCE_LABELS and keyChoicesFor, and needsHugepageComputeHint, which is chart-internal knowledge copied into the UI. The issue asks for image, affinity and environment settings, not a hugepages assistant.
• Duplicated logic in pdRoles.ts. extractStandaloneGpuTerm and extractAnyGpuProducts walk the same affinity tree with different filters. applyPdOverrides carries a long branch that rebuilds or nulls affinityReplace for the clear case. Writing the one role term and clearing it by removing that term would be much smaller. Several helpers (parseNonNegNumber, parsePosInt, hasAnyAffinityRule, expandProductValues, canonicalizeProducts) guard shapes that the dry-run output never produces.
• The compose dry run used to be gated on opening Images. It now always runs once the form is seeded, and again on target changes. That is an extra compose call on every Deploy/Upgrade open. It matches the commit "dryRun moved to window first open", so confirm that is intended. The new header "Refresh" button on both routes is a second control that does the same thing as the old Images refresh.

Low

• onRefresh ?? (() => {}) in PdRolesRows hides a missing prop. Make it optional on CapacityLine, or make it required.
• resources.test.ts, pdRoles.test.ts and DeploySettings.pd.test.tsx add about 700 lines, mostly testing the helpers listed above. They will shrink once the helpers do.
• Custom rows whose key matches the GPU resource or a base key are dropped from the emitted edits without a trace. That is only visible as the inline warning while the row is on screen.

Solid

• Old behaviour is kept: images still go through the form layer, dropClearedResources only removes scalars the form owns, and colocate mode keeps the top-level scheduling.
• The Images section moving into Advanced matches the issue.

Verdict: OK to merge as is. The Medium items are simplifications I would make before this grows further.

— Review Golden

[huskcass]

No blockers.

The previous Medium cuts landed: custom rows now live in the form as an ordered array (no draft state, refs or effect), the key dropdown, labels and hugepage hint are gone, pdRoles.ts reads affinity in one walk and the clear path just removes the role's term. expandProductValues/canonicalizeProducts are on the write path (applyPdOverrides), so keeping them is right. Conflicting custom rows are now kept with a warning.

• Low: clearRoleGpuTerm re-checks nodeAffinity / required being maps after nodeSelectorTermsOf already found terms; those two guards can go. formRoleGpu is a thin wrapper that can be inlined.
• Low: custom rows use key={i}; removing a middle row reuses the next row's inputs. Fine for controlled inputs, just noting it.
• Low: dry run on first open plus the header Refresh is unchanged; fine as the intended behaviour.

Verdict: good to merge.

— Review Golden