Skip to content

fix(mcpserver): honor warn_on_duplicate_resources for URI templates - #3814

Closed
jack12178 wants to merge 1 commit into
modelcontextprotocol:mainfrom
jack12178:fix/resource-template-duplicate
Closed

jack12178 wants to merge 1 commit into
modelcontextprotocol:mainfrom
jack12178:fix/resource-template-duplicate

Conversation

@jack12178

Copy link
Copy Markdown

Fixes #3813.

ResourceManager.add_template() registers templates with a bare dict assignment, so a second @server.resource("file://doc/{id}") silently replaces the first handler. add_resource(), PromptManager.add_prompt() and the documented warn_on_duplicate_resources setting all do the opposite: warn (when enabled) and keep the handler that was registered first.

That divergence is reachable without any unusual setup — two modules or extensions that both declare the same URI template end up with whichever one was imported last, and nothing in the logs says so:

server = MCPServer(warn_on_duplicate_resources=True)

@server.resource("file://doc")
def doc1() -> str: return "v1"

@server.resource("file://doc")
def doc2() -> str: return "v2"

@server.resource("file://doc/{id}")
def template1(id: str) -> str: return "template_v1"

@server.resource("file://doc/{id}")
def template2(id: str) -> str: return "template_v2"

Before: the static resource warns and keeps doc1, the template is replaced by template2 with no warning. After: both warn and keep the first registration, and add_template() returns the template that is actually registered (matching add_resource()'s return contract, now documented in the docstring).

Tests added to tests/server/mcpserver/resources/test_resource_manager.py, mirroring the existing resource-duplicate tests:

  • test_add_duplicate_template — the second registration returns the first template, list_templates() has one entry, and the retained handler is the first one.
  • test_warn_on_duplicate_templates — logs Resource template already exists: ....
  • test_disable_warn_on_duplicate_templates — silent when warn_on_duplicate_resources=False.

Results: on main the first two fail (2 failed, 12 passed); with the change the file is 14 passed. ruff format / ruff check: clean.

One judgement call worth flagging: I kept the existing template rather than replacing it, because that is what the sibling registration paths do and what the flag's docstring describes. If you would rather have last-registration-wins with a warning, the change is a one-line flip and I will adjust.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3813.

If a maintainer assigns you to #3813, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

@github-actions github-actions Bot closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ResourceManager.add_template() ignores warn_on_duplicate_resources and silently overwrites existing templates

1 participant