Skip to content

fix(ci): repair promotion verdict and report handoff - #42

Merged
mleem97 merged 2 commits into
mainfrom
fix/promotion-gate-handoff-main
Oct 30, 2026
Merged

mleem97 merged 2 commits into
mainfrom
fix/promotion-gate-handoff-main

Conversation

@mleem97

@mleem97 mleem97 commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

The dev → staging run 40654591700 failed before any gate because its checkout lacked .github/scripts/greg-gates.sh; issue #41 then received "no report". Current dev has also removed the GitHub workflow entirely during the Forgejo migration.

This change ships the complete GitHub gate resources together, validates evaluator exit status/verdict/report/checked-out SHA, and passes the run/attempt-specific artifact explicitly to the issue job. Missing scripts, crashes, malformed outputs, missing reports and missing artifacts produce concrete diagnostics. Existing blocked issues receive refreshed report bodies. An issue closes only after successful gates and a successful staging push.

Promotion retains the actor restriction, dry-run default, all existing main gate checks, coverage >=90% with <=5pp drop, security scanning and non-force fast-forward behavior. Missing staging history, failed Rust baseline coverage measurement and missing Cargo.lock now explicitly fail closed. Rust VERSION/Cargo consistency is checked alongside the existing consistency checks.

Rollout: this main PR follows AGENTS.md's feature-branch → main workflow; the companion targets dev under branch fix/promotion-gate-handoff-dev. Both PRs carry identical promotion workflow, gate script, operational documentation and regression tests and must be merged for the complete rollout. A main-only merge cannot repair dev. GitHub promotion is an intentional, requested exception to the older archive-only documentation; Forgejo/Gitea files are untouched. See .github/PROMOTION.md for runner requirements and rollout.

Validation:

  • python3 .github/tests/test_promotion.py: PASS, 4 test methods, including 10 evaluator cases and 7 actual-gate scenarios using isolated Git repositories and stub tools.
  • YAML parse, embedded Bash/script syntax and git diff --check: PASS.
  • Independent read-only review: no remaining blocker found.
  • Build and Release #112: real cargo test --workspace, Windows portable, Linux portable/distribution packages and macOS x64/arm64 builds passed. The Windows installer failed on an existing SourceDir path error: Inno resolves relative paths from build/installer, but the workflow passed dist/... as if it were relative to the repository root. The follow-up commit corrects this to ../../dist/... and verifies the Windows path against the actual xtask output. A fresh PR check run is pending.
  • Full promotion coverage/security checks on the configured self-hosted runner still have not run here. actionlint is unavailable locally.
  • After merge, run the new workflow with dry_run=true; the old completed run retains its old revision and should not be retried as validation. No staging push or merge was performed by this fix. Issue [staging-gate] dev -> staging blocked #41 remains open pending a real successful promotion.
  • CI-only changes: no user-facing changelog entry or wiki update needed; operational docs are in-repository.

Refs #41.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 21 complexity · 0 duplication

Metric Results
Complexity 21
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-30T05:34:14.453984Z 7877db2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mleem97
mleem97 merged commit 906afcd into main Oct 30, 2026
7 checks passed
@mleem97
mleem97 deleted the fix/promotion-gate-handoff-main branch October 30, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant