Skip to content

Reuse self.normal_data in StackedChart.draw() - #135

Open
mkaz wants to merge 1 commit into
mainfrom
reuse-stacked-normal-data
Open

mkaz wants to merge 1 commit into
mainfrom
reuse-stacked-normal-data

Conversation

@mkaz

@mkaz mkaz commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Chart.init already computes self.normal_data = self._normalize(), so StackedChart.draw() was normalizing the dataset a second time.

  • Reuse self.normal_data in StackedChart.draw(), matching BarChart and VerticalChart.
  • Add a regression test verifying StackedChart.draw() does not call _normalize() again.

Verified with just check and just test (91 passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant