Repository navigation
Document the connect-src requirement for locale files - #4
Merged
Merged
Conversation
The locale file is the only request the viewer makes for a locale once pdfjs-viewer 4.4.1 serves the locale map from memory, so a page CSP only needs the file's origin in connect-src, and a file that can't be loaded leaves the interface in English. Adds the sentence to Localization and a migration note for dropping `connect-src blob:`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The release that serves the locale map from memory, so the live preview and the version numbers match the Localization and Migrating notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alekswebnet
marked this pull request as ready for review
October 30, 2026 14:16
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with missing-elements/pdfjs-viewer#68, fixed in pdfjs-viewer 4.4.1 (missing-elements/pdfjs-viewer#69): the viewer no longer requests its locale map from a
blob:URL, and a locale file that can't be loaded leaves the interface in English instead of blank.connect-src(https://cdn.jsdelivr.netfor the default files,'self'for self-hosted ones) and the English fallback.connect-src blob:.@missing-elements/pdfjs-viewerto 4.4.1, so the live preview and the version numbers come from that release.Validation:
pnpm installandnpm run build(Eleventy) pass.🤖 Generated with Claude Code