Repository navigation
[Rewriter] Support omitted pads and ensure dtype safety in Conv affine fusion - #3213
Open
Hardik K (hardikkaurani) wants to merge 10 commits into
Open
Hardik K (hardikkaurani) wants to merge 10 commits into
Hardik K (hardikkaurani) wants to merge 10 commits into
Conversation
…eFusionBase Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
…nvFusion Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
…conv affine bias Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
… pads attribute Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
…ejection in AffineConvFusion Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
Contributor
Author
|
Hi Ti-Tai Wang (@titaiwangms), I've opened this PR to improve
All 12 dedicated tests and all 392 common rewriter tests pass locally. Whenever you have time, I'd appreciate your review and feedback. Thank you! |
…ence attribute rejection in Conv affine fusion Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
Hardik K (hardikkaurani)
force-pushed
the
fix/conv-affine-padding-and-dtype-safety
branch
from
November 14, 2026 22:46
e7fabb8 to
ea2d13f
Compare
…oading tensor data Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
…ine fusion Signed-off-by: Hardik Kaurani <hardikkaurani1@gmail.com>
Contributor
Author
|
Hi Ti-Tai Wang (@titaiwangms), I've pushed updates addressing the Copilot review feedback:
All 14 dedicated tests in |
Ti-Tai Wang (titaiwangms)
approved these changes
Nov 16, 2026
Contributor
Author
|
Thanks for the review and approval, Ti-Tai Wang (@titaiwangms)! All tests and checks are passing cleanly. Ready to be merged whenever convenient. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR improves
AffineConvFusionandConvAffineFusionin_fuse_conv_affine.pyby supporting omitted default padding attributes, validating padding configurations, and preserving weight and bias dtypes.Problem
Conv.padsto zero padding. The existing pattern required explicitpads=[0, 0, 0, 0], missing valid unpadded convolutions.auto_padvalues, and attribute references.DOUBLE, violating ONNX Conv dtype constraints.Solution
padsrequirement to support omitted default padding.pads,auto_padvalues ofNOTSETorVALID, and safe rejection of attribute references.tuple(range(1, w_value.ndim))..astype().pads,auto_padconfigurations, reference attribute rejection, and mixed-precision dtype preservation, including ONNX checker validation.