Skip to content

ci: run required workflows for merge groups - #2240

Merged
Gavin Barron (gavinbarron) merged 2 commits into
mainfrom
copilot/merge-group-java-20261109
Nov 9, 2026
Merged

Gavin Barron (gavinbarron) merged 2 commits into
mainfrom
copilot/merge-group-java-20261109

Conversation

@baywet

@baywet Vincent Biret (baywet) commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

Add plain merge_group: triggers (null value, without an explicit types restriction) to the three workflows producing required Actions checks. Existing jobs have no PR-only event conditions or payload references and already use the checked-out event revision, so no job changes are needed.

Required-check evidence

Reviewed recent merged PR #2237 (merged November 5, 2026).
gh pr checks 2237 --required and the effective rules endpoint (repos/microsoft/kiota-java/rules/branches/main, active ruleset 26719695) agree on these required checks:

Required check Workflow / provider Reviewed run
build .github/workflows/build.yml (Gradle Build And Test) https://github.com/microsoft/kiota-java/actions/runs/41926319933
lint-api-level .github/workflows/api-level-lint.yml https://github.com/microsoft/kiota-java/actions/runs/41926319356
Analyze (java) .github/workflows/codeql.yml (CodeQL) https://github.com/microsoft/kiota-java/actions/runs/41926319153
license/cla External Microsoft GitHub Policy Service app Not an Actions workflow; unchanged

Run metadata confirms the three workflow paths. Other observed checks (including Build, SonarCloud and changelog guard) are not required by the effective status-check rules and are intentionally unchanged. No rules or merge settings are changed.

Validation

  • Read repository CONTRIBUTING guidance; isolated worktree based on origin/main, original checkout/index left unchanged.
  • git diff --check: passed.
  • Exact-content assertions: only one plain merge_group: trigger line added per workflow; no PR-only event/payload coupling.
  • Actionlint: unfiltered baseline and changed files both report the same pre-existing undefined inputs.componentName in build.yml. With only that exact diagnostic ignored, all three changed workflows pass. This unrelated issue is not changed here.
  • No Java tests run: changes only enable existing workflows on another event.

Limits

Classic branch protection endpoint returned HTTP 404, but effective branch rules and required PR checks were accessible and consistent. External CLA merge-queue behavior is not controlled by these workflows. Actual merge-group execution must be verified when queued after landing; this PR does not merge or enqueue anything.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: db7b6607-701f-4239-8458-c841b7bb0bec
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner November 9, 2026 14:44
Copilot AI balanced review requested due to automatic review settings November 9, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the changes enabling required workflow checks on merge-queue groups.

No open issues 🎉

What changed in this PR

Enables the three workflows that produce required Actions checks to run for merge-queue groups, so queued changes can receive those checks.

Changes:

  • Adds merge_group with types: [checks_requested] to the build, API-level lint, and CodeQL workflows.
  • Leaves existing triggers, jobs, branch rules, and the external CLA check unchanged.
File Description
.github/​workflows/​codeql.yml Enables CodeQL analysis for merge groups.
.github/​workflows/​build.yml Enables Gradle build and tests for merge groups.
.github/​workflows/​api-level-lint.yml Enables API-level compatibility checks for merge groups.

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: db7b6607-701f-4239-8458-c841b7bb0bec
Copilot AI balanced review requested due to automatic review settings November 9, 2026 14:56
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the workflow-trigger updates supporting merge-queue validation.

No open issues 🎉

Review effort: Balanced

@github-project-automation github-project-automation Bot moved this to In Progress 🚧 in Kiota Nov 9, 2026
@gavinbarron
Gavin Barron (gavinbarron) added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit f96d8bc Nov 9, 2026
12 checks passed
@gavinbarron
Gavin Barron (gavinbarron) deleted the copilot/merge-group-java-20261109 branch November 9, 2026 18:39
@github-project-automation github-project-automation Bot moved this from In Progress 🚧 to Done ✔️ in Kiota Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

3 participants