[Hardik K (hardikkaurani)]

Description

This pull request addresses missing type support in form serialization and deserialization components:

1. *Support \Double\ in \FormSerializationWriter.writeAnyValue*

   • While \FormSerializationWriter.writeDoubleValue\ is provided, \writeAnyValue\ previously lacked handling for \Double.class, which caused collection serialization (\writeCollectionOfPrimitiveValues) and additional data serialization containing double values to fail with \RuntimeException: unknown type to serialize java.lang.Double.
   • Added \Double.class\ branch mapping to \writeDoubleValue.

2. *Support \�yte[]\ and Enum Values in \FormSerializationWriter.writeAnyValue*

   • Added support for \�yte[].class, delegating to \writeByteArrayValue\ (Base64 URL-encoded serialization).
   • Added support for \ValuedEnum\ and \Enum<?>, writing their string representations (\getValue()\ /
     ame()) consistently with other Kiota serialization writers.

3. *Support \�yte[]\ in \FormParseNode.convertPrimitiveValue*

   • \FormParseNode\ supported single \getByteArrayValue()\ via Base64 decoding, but \convertPrimitiveValue\ lacked a branch for \�yte[].class, throwing \RuntimeException: unknown type to deserialize [B\ when calling \getCollectionOfPrimitiveValues(byte[].class).
   • Extracted shared \parseByteArrayValue\ static helper and added \�yte[].class\ handling to \convertPrimitiveValue.

4. Tests

   • Added regression tests in \FormSerializationWriterTests\ verifying serialization of doubles, byte arrays, and enums in additional data and primitive collections.
   • Added regression test \parsesCollectionOfByteArrayValues\ in \ParseNodeTests.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Hardik K (hardikkaurani)]

Hi Vincent Biret (@baywet),

Opened this PR to address a few type serialization gaps in the form serialization components:

• \FormSerializationWriter.writeAnyValue\ was missing handlers for \Double.class, \�yte[].class, and \Enum/\ValuedEnum, which caused runtime exceptions when serializing collections of primitives or entities with these types in \�dditionalData.
• \FormParseNode.convertPrimitiveValue\ was similarly missing \�yte[].class\ handling for \getCollectionOfPrimitiveValues(byte[].class).

Added regression tests covering primitive collections and additional data for all three types, and verified all unit tests and spotless formatting pass locally. Whenever you have a chance, please take a look.

[Copilot]

🟡 Changes recommended

Byte-array collection parsing corrupts Base64 values containing + through double URL decoding and treats null markers as byte arrays, breaking round-trip behavior.

2 open issues

• Avoid double URL decoding Base64 collection values · New
• Recognize null markers in byte-array collections · New

_{Review effort: Balanced}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Hardik K (hardikkaurani)]

Vincent Biret (@baywet) Addressed the review feedback regarding collection byte array handling: removed the redundant URL decoding in \FormParseNode\ so Base64 values containing +\ are not corrupted, and added null-marker recognition in \parseByteArrayValue\ so null elements in collections deserialize to
ull. Added regression and round-trip tests covering both cases; all unit tests and Spotless formatting pass cleanly.

[Copilot]

🟢 Approval recommended

No active review issues block approval of the form serialization changes.

No open issues 🎉

2 resolved since last review

• Recognize null markers in byte-array collections
• Avoid double URL decoding Base64 collection values

_{Review effort: Balanced}

[Hardik K (hardikkaurani)]

Thanks for the review Vincent Biret (@baywet) .

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[Hardik K (hardikkaurani)]

Vincent Biret (@baywet) Reverted the settings.gradle change to keep this PR strictly focused on the form serialization improvements. The change was initially introduced in response to a transient CodeQL autobuild failure caused by plugins.gradle.org failing to resolve Spotless plugin dependencies. All form serialization tests and build checks continue to pass cleanly.

[Copilot]

🟢 Approval recommended

There are no active review issues for the form serialization and byte-array deserialization changes.

No open issues 🎉

_{Review effort: Balanced}