Repository navigation
Add policy-gated ETW logging for sidecar GCS - #2982
Open
Manish Ranjan Mahanta (marma-dev) wants to merge 2 commits into
Open
Manish Ranjan Mahanta (marma-dev) wants to merge 2 commits into
Manish Ranjan Mahanta (marma-dev) wants to merge 2 commits into
Conversation
added 2 commits
November 5, 2026 21:52
Signed-off-by: Manish Ranjan Mahanta <mmahanta@microsoft.com>
Signed-off-by: Manish Ranjan Mahanta <mmahanta@microsoft.com>
Manish Ranjan Mahanta (marma-dev)
force-pushed
the
sidecar-gcs-etw-logging
branch
from
November 5, 2026 16:23
06b5d20 to
03b8e51
Compare
Manish Ranjan Mahanta (marma-dev)
marked this pull request as ready for review
November 5, 2026 16:30
Manish Ranjan Mahanta (marma-dev)
requested a review
from a team
as a code owner
November 5, 2026 16:30
Justin (jterry75)
approved these changes
Nov 5, 2026
| logrus.WithError(err).Error("failed to register sidecar ETW provider") | ||
| } else if hook, err := etwlogrus.NewHookFromProvider(provider); err != nil { | ||
| logrus.WithError(err).Error("failed to initialize sidecar ETW hook") | ||
| if err := provider.Close(); err != nil { |
Contributor
There was a problem hiding this comment.
We close on error but dont defer a close on success else. Do we need one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation performed
Compatibility and coverage notes