Repository navigation
Desktop testing: migrate stories and split CI input lanes - #4466
Open
Jason Morse (JasonVMo) wants to merge 5 commits into
Open
Jason Morse (JasonVMo) wants to merge 5 commits into
Jason Morse (JasonVMo) wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Finish part 1 of the input-lane work started in f5a90cd. Cases declare how they run with desktopIt, and a run selects the cases that apply to its input lane, platform and scope and accounts for everything it excludes. desktop-driver - Add pure case selection and click-mode resolution, and move the requirement preflight and click-mode helpers here. - Add the authoring/input leaf export so config-loading code can import scope helpers from source without the authoring index. desktop-test - Report the lane: a lane run is incomplete when it has skipped or undeclared-unsupported results, an empty selection or nothing executed. - Add the Jasmine adapter (desktop-test/jasmine) with desktopIt and desktopDescribe, plus config-level test scopes and --input. storybook-desktop - Add --input accessible|physical to storybook test, driver and smoke. The lane comes from the flag, DESKTOP_INPUT or the attached driver. - Select cases before they run, resolve declared gaps, assess each cohort, and reject direct input calls in declared cases at extraction. - Fail closed when an accessible lane attaches to a driver that does not mask keyboard, physical click and wheel input. native-core and apps/E2E - Migrate the native-core Callout and FocusZone tests and ButtonV1.spec.win.ts to desktopIt. Update the package references and add patch changesets. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace remaining component story runtime skips with desktopIt requirements, platform scopes and declared gaps. Carry the Win32 preview fixes from #4431 and split accessible and advisory physical Storybook CI lanes without changing aggregate PR requirements. Co-authored-by: Srividya Ramaswamy <sriramas@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrate merged phase 1 (#4464) and the package-version release without rewriting phase 2 history. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Jason Morse (JasonVMo)
enabled auto-merge (squash)
November 7, 2026 08:35
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Phase 2, following the merged descriptor/selection infrastructure in #4464. The branch includes the latest
main(8574d22ee) through merge commitd546ac30b; the PR diff contains only this follow-up.desktopItdescriptors. One macOS-specific Button transport split produces 89 cases. Preserve assertions while moving capability/platform gates and known gaps out of callbacks; remove runtimeskipcalls and the internalrequireDesktopFocushelper. Read-only cases retain derivedboth. The Win32 pressed-state quarantine (Components: Win32 Button does not report onPressOut after Space with an intervening key #4373) expires on2027-01-31.--input accessibleand physical input masked. Add a separate, unmasked Win32--input physicalpilot with distinct artifacts. No Storybook job is added to the aggregatePRcheck. macOS CI remains in compatibility mode. Physical-lane promotion remains governed by Infrastructure: Qualify and require native Storybook CI coverage #4349.Session-level input enforcement and mechanism receipts remain phase 3. Static selection counts are not evidence of delivered input: Win32 selects 38 accessible cases and 83 physical cases, with one of the latter declared quarantined.
Verification
Passed on the main-integrated branch:
yarn install --immutable— passed.yarn clean-lage-cachefollowed byyarn lage buildci— passed, 178 successful tasks, zero failed or cached tasks. Includes package builds, lint, tests, story typechecking, contract checks, repository formatting, and agent-instruction validation.yarn change:check— passed with committed changesets.yarn lage test-links— passed, 90 successful tasks.git --no-pager diff --check origin/main...HEAD— passed.From
apps/storybook, all of the following passed after the merge:yarn storybook manifest --macos;yarn storybook test --macos --list --input accessible;yarn storybook test --macos --list --input physical;yarn storybook bundle --macos.yarn storybook manifest --windows;yarn storybook test --windows --list --input accessible;yarn storybook test --windows --list --input physical;yarn storybook bundle --windows.yarn storybook manifest --win32;yarn storybook test --win32 --list --input accessible;yarn storybook test --win32 --list --input physical;yarn storybook bundle --win32.Not run locally: native app smokes, physical-input runs, or assistive-technology qualification. Win32 native execution requires Windows. JavaScript tests and bundles do not qualify the native viewport behavior or hosted input delivery; the new CI lanes still need execution evidence.
Pull request checklist
This PR has considered (when applicable):
Native keyboard, VoiceOver, and right-to-left UI checks were not run locally; existing story assertions are preserved.