[Chiara Mooney (chiaramooney)]

Description

Improves the non-AI XAML Quick Fixes for misspelled property names and values. Name and value fixes stay separate, reusing the existing spelling-fix path:

• Related names: when no typo match exists, an unknown property name can fall back to up to three related names, closest first. Words shorter than 3 letters (such as Is) never count as shared. They are completions of a partially typed name (Visib -> Visibility), or else the names sharing the most whole words with it (FrozenColumnCount -> FrozenEdge, BackgroundColor -> Background). Related names are never the preferred (Auto Fix) action.
• Typos: swapped letters count as one typo (Txet -> Text).
• Booleans: misspelled Boolean values suggest True/False (Ture -> True) instead of always replacing with False.

Usage Example

<!-- input -->
<tabular:TableViewTemplateColumn FrozenEdgeCount="1" />

<!-- quick fix: Change 'FrozenEdgeCount' to 'FrozenEdge' -->
<tabular:TableViewTemplateColumn FrozenEdge="1" />

Related Issue

N/A

Type of Change

• ✨ New feature
• 📝 Documentation
• 🧪 Test update

Checklist

• New tests added for new functionality (if applicable)
• Ran .\scripts\build-vsce.ps1 locally
• Tested locally on Windows (if applicable)
• README.md updated (if applicable)

Screenshots / Demo

N/A

Additional Notes

Validation run on the current head:

• dotnet test server\test\WinUiXaml.LanguageServer.Tests (full language-server suite): passed (1036/1036) after rebasing onto main.
• npm run test:xaml-smoke: passed, including real-SDK cases Gird, Txet, Ture, Strech, MaxHieght (preferred typo fixes), VisibilityCount, Visib, ForegroundColor, and BackgroundColor (unpreferred related names).
• .\scripts\build-vsce.ps1 -Package: passed (72.5 MB VSIX with the Native AOT server for win-x64 and win-arm64).

AI Description

This section is auto-generated by AI when the PR is opened or updated. To opt out, delete this entire section including the marker comments.

[github-actions]

⏳ Build in progress — the VSIX size below is from a previous commit and will update when the current build finishes.

VSIX Build

Artifact	Baseline	Current	Delta
VS Code Extension (VSIX)	72.44 MB	72.46 MB	📈 +26.8 KB (+0.04%)

---

Updated 2026-11-12 21:03:10 UTC · commit 70535d3 · workflow run

[Jaylyn Barbee (Jaylyn-Barbee)]

PR review (automated, scope: 10 files, +317/-12)

No critical or high findings. Spelling-fix path, Related wire flag (typed and JsonElement reads), preferred-action suppression, and swap-aware Distance (early-bail pruning stays valid for the transposition term) check out.

Medium

• XamlCodeActions.cs (InvalidAttributeValueCode case): the mechanical default-value fix is now skipped whenever any suggestion exists. For booleans that is intended (Ture -> True). Please confirm the same skip is acceptable for enum-typed values where a weak Levenshtein match previously fell through to the default-value fix; a test for a non-boolean enum with a near-miss value would pin this.

Low

• XamlSuggestions.RelatedNames: Words() and Distinct() run over every candidate for each unknown attribute on each validation pass. Fine for typical types, but worth a quick check on types with very large attribute sets (e.g. FrameworkElement derivatives with many attached names).
• RelatedNames completions bypass the 3-letter word rule (only target.Length >= 3), so short prefixes like Wid/Hei produce completions; this looks intended, a test documenting it would help.
• Tests: no negative test showing a Related suggestion is never IsPreferred when the diagnostic goes through the real validator (only the wire-shape test covers it for the BackgroundColor case).

Docs: README Code actions row updated. Packaging/security: no impact found (no new inputs, no manifest/pipeline changes).

[Jaylyn Barbee (Jaylyn-Barbee)]

PR review #2 (head 70535d3, independent model: GPT-6.1 Sol)

No critical or high findings.

Medium

• XamlSuggestions.cs:159-163 with XamlValidator.Elements.cs:327-340: transposition matching now accepts swallowed markup. For a resolved Button, Visibility="Visbile/> yields the suggestion Visible (distance 3, previously 4). The parser includes /> in the unterminated value, so the preferred spelling action replaces the whole span, deleting the tag terminator without restoring the quote. Suggest suppressing value replacements for unterminated or markup-swallowing spans, and adding malformed-quote regression tests.

No other significant security, performance, or docs findings. Builds and tests were not run in this review.

[Chiara Mooney (chiaramooney)]

🤖 AI-assisted reply, verify before acting.

Thanks Jaylyn Barbee (@Jaylyn-Barbee)! Responses to both reviews:

Swallowed markup (review #2, medium): fixed in d7e9b1d. Reproduced: Visibility="Visbile/> at end of file offered a preferred Change 'Visbile/>' to 'Visible' that deleted the />. Invalid values now get spelling suggestions, and the "Replace with default" fix, only when the value is a closed, single-line literal with no quote or markup characters. The new UnterminatedValueSwallowingMarkup_OffersNoValueReplacement test covers Visbile/> (enum) and Ture/> (Boolean); both failed before the fix.

Default-value fix skipped for enums (review #1, medium): no behavior change for enums. GetDefaultLiteral returns null for enum types, so main never offered a default-value fix for an enum value. Skipping it when suggestions exist only affects Booleans, where Ture -> True is the intended result.

Low items, not changing:

• RelatedNames cost: it runs only for an unknown property name with no typo match, over that element's property names, so it's linear in a few hundred names.
• Completions with short prefixes (Wid, Hei) are intended (3-character minimum); Font and Visib in XamlSuggestionsTests document it.
• RelatedPropertyName_IsAnUnpreferredRenameThatKeepsTheValue already runs the real validator and asserts the related fix is not preferred.

[Jaylyn Barbee (Jaylyn-Barbee)]

PR review #3 (head d7e9b1d, independent model: Claude Opus 5.5)

No critical, high, or medium findings. The latest commit fully fixes the earlier swallowed-markup finding: unterminated values (run to EOF) are rejected by the closing-quote check, and values closed by a later quote are rejected via NonLiteralChars (>, =, <, newline, other quote). Both the suggestion data (XamlValidator.Elements.cs) and the default-value fix (XamlCodeActions.cs) are guarded. The swap-aware Distance early-exit remains correct.

Low

• Test coverage: UnterminatedValueSwallowingMarkup_OffersNoValueReplacement only uses inputs that run to end of file, so the IndexOfAny(NonLiteralChars) branch is not exercised. Add a case closed by a later quote, e.g. Visibility="Visbile/> followed by <Grid Tag="x"/>, or IsEnabled="Ture Tag="x"/>.
• Informational, pre-existing and out of scope: the same EOF /> deletion can occur for Setter attached-property members (XamlValidator.Elements.cs ~643) and x:Bind Mode (XamlValidator.Bindings.cs ~244). Reusing IsClosedLiteral there would harden them.

Builds and tests were not run in this review.

[Jaylyn Barbee (Jaylyn-Barbee)]

LGTM