Repository navigation
FIX: Detect modern OpenSSH private keys in PathTraversalOutputScorer (#4232) - #4233
Open
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Open
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Vardhman Gupta (Kaap10) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends
PathTraversalOutputScorerto detect traversal payloads targeting modern OpenSSH default private key filenames (id_ed25519,id_ecdsa,id_dsa, and FIDO2id_ed25519_sk/id_ecdsa_sk) alongsideid_rsa._DEFAULT_PATTERNS["Path Traversal to Sensitive File"]inPathTraversalOutputScorerto matchid_(?:rsa|dsa|(?:ecdsa|ed25519)(?:_sk)?)while preserving existing_FILE_ENDboundaries.id_dsa,id_ecdsa,id_ed25519,id_ecdsa_sk,id_ed25519_sk, backslash separators, percent-encoding, null-byte truncation (%00), and sentence-ending periods..pubpublic keys,.bakbackups, custom suffixes (id_ed25519_custom), and single-parent walks (../.ssh/id_ed25519) remainFalse.Demonstration
For
"../../.ssh/id_ed25519":score_value="false"(rationale:"")score_value="true"("Matched: Path Traversal to Sensitive File")For
"../../.ssh/id_ed25519.pub":score_value="false"(public key safely excluded by_FILE_END)Closes #4232