Skip to content

Nightly sites: always commit history, so each run deploys with a new sha - #3067

Merged
willend merged 1 commit into
mainfrom
nightly-site-unique-sha
Nov 7, 2026
Merged

willend merged 1 commit into
mainfrom
nightly-site-unique-sha

Conversation

@willend

@willend willend commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

The 2026-11-07 McStas nightly deploy reported success in 7 seconds, but the site still served 2026-11-06 (https://github.com/mccode-dev/mcstas-nightly/actions/runs/42354978546).

deploy-pages uses GITHUB_SHA as the Pages deployment id, and a nightly run's GITHUB_SHA is the nightly repo's latest commit when it starts. A redeploy that changed no history made no commit, so the next night started from the same commit as an already-successful deployment. deploy-pages then read that old deployment's status and reported success without the new upload being published.

The history step now always commits (--allow-empty), so every run's successor starts from a new commit.


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Claude Code traced the silent deploy through the run logs and the deploy-pages source, and made this change.

Development OS / boundary conditions

Edited on macOS. No new dependencies. The workflow change has not run on GitHub yet.


PR Checklist for contributing to McStas/McXtrace

  • My contribution contains something else

    • Explanation is added in free form text above or below the checklist

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@willend
willend merged commit 48eb88a into main Nov 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant