Repository navigation
Add opt-in OpenSSL TLS key logging for clients and servers - #661
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in TLS session key logging through
SocketTLSOptions::keyLogFilefor OpenSSL 1.1.1 and newer, for clients and servers.wsTLS commands expose--keylog-fileandSSLKEYLOGFILE, with the command-line option taking precedence. Empty options keep library logging disabled, and unsupported backends report an explicit error.Each TLS context retains its socket's configuration through OpenSSL's application-data API. The callback appends NSS-format lines, serializes appends when connections share a file, and preserves the socket error state. There is no global connection/context lookup table. An unwritable destination fails connection initialization; callback exceptions do not cross the C API. API and CLI usage are documented.
Closes #499.
Validation: