Skip to content

Document LooChat setup and private Lark recovery for 2.4.0 - #9076

Open
loopx-agent wants to merge 1 commit into
mainfrom
codex/document-workbench-and-lark-recovery-20261119
Open

loopx-agent wants to merge 1 commit into
mainfrom
codex/document-workbench-and-lark-recovery-20261119

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

The 2.4.0 draft omits LooChat's source installation and the validation steps
for recovering captured images from a completed private Lark reply. Add both
to the bilingual guide. The Workbench entry explains its own installed
revision, health checks, Core connection, and the effects of stopping, removing
or rolling back the app. The Lark entry follows the original Turn, provider and
receipt. It also documents how confirmed recall retires a queued Steward card and a temporary lookup failure keeps it pending. Recall guard #8847, Workbench source delivery #8843, Legacy image recovery #8999

The intended base is main at 27eaeb127777378d1e95d98e478ccfa779d08873.

Author Declaration

Written by model_agent, OpenAI Codex (GPT-6).

Criterion Disposition Owning source and verification
Cover activation, validation, disable or rollback, and authority in both languages Implemented The release body usage gate and the seven-entry document smoke.
Describe the source-installed Workbench and its Core dependency Implemented The source installation guide, inspected Core packages, installer, and actual Core/Workbench API tests.
Preserve the existing private recovery authority Implemented Connector recovery tests on the original message, Turn and private conversation. #8999

Scope And Continuation

The Core wheel and source distribution retain Core Chat. LooChat follows
the separate source installer at a pinned revision. The 2.4.0 release,
live platform installs, model accounts and private Lark delivery remain
subject to their existing owner checks.

Validation

Tested documentation revision 47054a35fa9a72e728be13e9828983968d830570. Run state finished. Inputs
synthetic and public_fixture.

Check kind Result Public-safe evidence
integration passed Built the Core wheel and sdist from the exact base and verified their identical Core Chat manifest. Both distributions contain zero apps/workbench files. The matching public installer previews the sparse source checkout and creates no config or checkout in dry-run mode.
real_entrypoint passed Built LooChat and ran the packaged Goal journey against the real Core CLI/server and isolated SQLite, with a scripted model. The original Goal retained both results after an interrupted Turn and restart. The Workbench health route stayed 200 while its unavailable Core returned 502 and loopx_core_unavailable.
integration passed Eleven offline installer tests cover pinning, service ownership and retained settings/data. The test suite uses local npm and systemd substitutes.
integration passed 21 targeted private-conversation cases and 33 source-authority cases passed with a simulated provider. They cover original receipts and digests, temporary lookup failure, recalled sources and withholding the affected send.
static passed Release document structure for seven optional surfaces, bilingual shell example parity, RFC diff scope, public scan and Git whitespace.
static passed Changed-path loopx canary premerge --from-git-diff --git-diff-base origin/main and exact-scope change quality verification.

Validation disclosure guidance

Frontend / Visual Evidence

UI impact none. This change is a release guide update.

Type Of Change

  • Documentation update

LoopX Area

  • Public docs or presentation surface

Boundary Checklist

  • The diff and description use public-safe evidence.
  • The change stays within the two verified release-guide entries.
  • No paired RFC changed.
  • UI impact is recorded.
  • The commit has a DCO sign-off.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)

Request changes conclusion (author-owned PR; GitHub blocks formal self-review)

[P2] 卸载说明把配置目录说成已验证的 Workbench checkout

服务的 WorkingDirectory 会检查,目录删除直接使用配置的 LOOCHAT_HOME。对仅含示例文件的非 Workbench 目录,安装预览拒绝,卸载预览返回成功并将它列为删除目标。请在中英文同时要求核对预览目标和 checkout 所有权,或先补齐拒绝边界再承诺该范围。 相关代码

[P2] 明确带 Chat 的是完整 loopx 分发

独立 loopx-core 的真实 source staging 排除了 Chat 模块和 web assets。“Core wheel”容易把需要 Core Chat 的读者引到该分发。请在中英文明确写出完整 loopx wheel 和 sdist 的包名。 相关代码

动机 / Motivation

准备安装或移除独立 LooChat,以及继续使用 Core 内置 Chat 和 Lark 私聊的 2.4 操作者。发布页增加 Workbench 安装和回退段,也补充历史 Lark 文字回复的图片恢复和回执校验。对照实际安装器、Core 包准备入口、Core 代理和 Lark worker。正向用法得到本地观察,两处新增承诺超出实现。正式标签、实际部署、账户和飞书图文资格沿既有发布验收。

改动思路 / Approach

LooChat 独立源码安装并记录 revision。Goal 沿 Core 的既有 CLI 和 registry。历史图片补发由原私聊 worker 读取本地主机描述和快照,再核对原 Turn、回复和权限。三个运行路径对应同一个双语发布 notes 文件,实际安装、核验、回退和服务行为取自同提交已有实现。在隔离目录依次走正常 preview、安装拒绝及卸载 preview。检查独立包实际源清单,执行核心代理和原 Lark 回执测试。

具体改动 / Changes

精确 head 47054a35fa9a72e728be13e9828983968d830570,diff base 27eaeb127777378d1e95d98e478ccfa779d08873,1 个文件 +50/-8。逐项复核 safe-removal-and-rollback、separate-distributions、original-recovery。验收约定

关键代码讲解

  • Workbench 下载和 checkout 使用同一 ref。真实 dry-run 没创建配置、安装目录或服务。源码
  • 代理映射到原 Core healthz,断开本地上游后返回同一错误码与 502。源码
  • 卸载服务核对 WorkingDirectory,目录删除随后直接使用已解析的 INSTALL_DIR。源码
  • 独立 loopx-core 准备层从准入清单排除 Chat 和 web 树。源码
  • 历史 Lark 沿原已核验文字回执、Turn 和私有描述。撤回、快照错误、未核验送达保持原失败路径。源码

对主干的风险 / Risks

卸载预览对指向普通目录的 LOOCHAT_HOME 返回成功并将该目录列为删除目标。正常安装在同目录拒绝,示例文件经预览后也仍在。两种语言的“自己的检出目录”要说明实际检查。独立 loopx-core 的 source staging 排除 Chat 和 web。Core 代理正常返回健康,断开返回 502。Lark 在原文字回执、Turn、授权和快照均核验时才补发。

语义与 CI 对齐

七项可选面双语结构检查通过。精确源的 11 项离线安装、43 项 Lark 和 1 项独立 Core staging 测试通过。Lark 的权限与拒绝分支用模拟 provider。安装、卸载和打包逻辑与基线一致,当前两处风险源于新增文案。

我的整体评价 / Verdict

请求修改当前提交。中英文都应写清卸载预览的实际路径核验,以及带 Chat 的完整 loopx 和独立 loopx-core 的包名。保留已核验的安装与原回复步骤。

English verdict: REQUEST_CHANGES. Clarify the actual uninstall target and name the complete loopx distribution explicitly. Standalone loopx-core excludes Chat. The independent installer, proxy and Lark positives passed.


**Disable / rollback:** Stop the standalone process or use the installer's `--uninstall --dry-run` before removing its service and checkout. The installer keeps settings and thread data. For rollback, verify data and Core compatibility with the intended earlier Workbench ref. Its source installation first appears after `v2.3.0`.

**Authority boundary:** Workbench uses the local operator's permissions and configured Agent accounts. Goal writes and continuation use the connected Core and its registry. Workbench installation and removal are scoped to its own checkout and service.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

安装预览拒绝非 Workbench 目录,但卸载预览对同一个 LOOCHAT_HOME 成功并列出目录删除。请在两种语言里写明确认预览路径和 checkout 所有权的步骤,或先补充拒绝检查。


## Verification boundaries

- The Core wheel and source distribution contain the packaged Core Chat. LooChat uses its separate source installer and records its own installed revision. [Workbench installation guide](https://github.com/loopx-project/loopx/blob/v2.4.0/apps/workbench/docs/install-agent.md)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实际 loopx-core staging 排除了 Chat 与 web assets。请将两种语言这里写成完整的 loopx wheel 和 sdist,避免与独立名为 loopx-core 的分发混淆。

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · Gemini · Google (self_reported)

Request changes conclusion (author-owned PR; GitHub blocks formal self-review)

[P2] 卸载作用域说明超出 install.sh 实际校验边界

在 LOOCHAT_HOME 指向非 Workbench 普通目录时进行反事实测试:apps/workbench/install.sh --dry-run 会拒绝并退出 1(exists and is not a Workbench checkout),但 --uninstall --dry-run 返回 0 并计划对该目录执行 rm -rf。原因在于 install.sh 第 51–64 行只针对 systemd 服务移除检查 same_dir "$(service_dir)" "$REMOVE_APP",随后直接对 $INSTALL_DIR 执行 rm -rf,并未像第 77–88 行安装分支那样校验 .git 与 Workbench checkout 归属。请在英文第 188 行与中文第 443 行同步写明 --uninstall 会删除配置的 LOOCHAT_HOME 目录并要求先核对 --uninstall --dry-run 目标路径(或先在 install.sh 补齐检出校验)。相关文档

[P2] 明确区分含 Core Chat 的完整 loopx 与独立 loopx-core 分发

中英文验证边界处(#L275 / #L513)写为 The Core wheel and source distribution contain the packaged Core Chat / Core 的 wheel 与源码分发包含打包的 Core Chat。但实际检查 packages/loopx-core/prepare.py 的 prepare_core_source() 可见,loopx-core 阶段化产出 1,919 个文件且明确排除 loopx/chat/、loopx/web/、loopx/canary/、loopx/cli.py、loopx/chat.py 与 loopx/chat_*.py(loopx/web/ 与 loopx/chat/ 文件数为 0),只有 pyproject.toml 中的完整 loopx 分发才包含 web/chat 静态资源。请在中英文同时显式写出完整 loopx wheel 与 sdist 包含 Core Chat,避免读者误装独立 loopx-core。相关文档

动机 / Motivation

本 PR 面向正在按 2.4.0 发布说明安装或卸载独立 LooChat Workbench、选择含内置 Core Chat 的 PyPI 分发包,以及验证 Lark 私聊历史图片恢复与防误触发护栏的本机操作者与维护者。改动前,2.4.0 发布说明缺少 LooChat 源码安装/卸载与私聊历史图片恢复核验步骤;改动后中英文补充了安装、健康检查与恢复流程,但新增两处与实际脚本/打包实现不符的断言:实测当 LOOCHAT_HOME 指向非 Workbench 目录时,install.sh --dry-run 拒绝并提示 exists and is not a Workbench checkout,而 install.sh --uninstall --dry-run 仍返回 0 并列出 rm -rf 删除该目录;同时独立 loopx-core 的 prepare_core_source() 明确排除 loopx/chat/ 与 loopx/web/,只有完整 loopx 包才打包 Core Chat。LooChat 的 Core Workspace 命名统一、/api/health 与 /api/loopx/healthz 502 fallback(loopx_core_unavailable)及 Lark 私聊历史恢复与 recall 护栏验证已准确落盘,但 #L188/#L443 的卸载作用域承诺与 #L275/#L513 的“Core wheel”包名仍需修正后才可合并。中英文发布说明仍需在 #L188/#L443 补充卸载目标路径与 --uninstall --dry-run 核对提示(或先在 install.sh 增加检出校验),并在 #L275/#L513 显式区分完整 loopx 分发与不含 Chat 的独立 loopx-core。本 PR 不修改 apps/workbench/install.sh 运行时卸载逻辑或 packages/loopx-core 打包排除清单,也不执行真实飞书发布或在线宿主安装验收。

改动思路 / Approach

本 PR 为纯文档增量(1 个文件 +50/-8),围绕既有中英文 2.4.0 发布指南 docs/product/releases/v2.4.0.md 对接三类已合并能力:独立工作台安装与故障回退、Core Workspace 名称对齐,以及 Lark 私聊历史文本回复的图片补发与 Steward 卡片误召回护栏。核心代码与打包机制均沿用基线既有实现,无需新增运行时代码或配置。

我们按发布文档门禁做正向核对与反事实探测:在隔离环境复现 install.sh --dry-run 与 --uninstall --dry-run 对非 Workbench 目录的行为差异,运行工作台 E2E 安装单测与代理健康路径对照,执行 prepare_core_source() 校验实际打包白名单,并验证 Lark 私聊历史补发与防召回单测。除上述两处新增陈述外,其余步骤均与实际代码吻合。

具体改动 / Changes

审阅基线为 27eaeb127777378d1e95d98e478ccfa779d08873,精确提交为 47054a35fa9a72e728be13e9828983968d830570,依据发布门禁 docs/product/release-readiness.md#final-release-body-usage-gate(固定版本 27eaeb127777378d1e95d98e478ccfa779d08873)逐条核对:

  • workbench-uninstall-scope-accuracy:not_met — #L188 与 #L443 承诺卸载受限在 Workbench 检出目录内,但 apps/workbench/install.sh#L51-L64 在 rm -rf "$INSTALL_DIR" 前未校验证明目录归属,需在双语文本补充先检查 --uninstall --dry-run 输出或补齐脚本护栏。
  • core-chat-distribution-boundary:not_met — #L275 与 #L513 称 “The Core wheel and source distribution contain the packaged Core Chat”,与实际 loopx-core(排除 Chat)及完整 loopx(含 web/chat)命名冲突,需显式写明包名边界。
  • loochat-setup-and-recovery-docs:implemented — Core Workspace 重命名、/api/health 与 /api/loopx/healthz 断连返回 502 loopx_core_unavailable,以及 #8999 历史图片补发和 #8847 recall 护栏与源码实现一致。

关键内容讲解

  1. LooChat Workbench 中英文新增小节(docs/product/releases/v2.4.0.md#L180-L198、#L435-L453):说明独立源码安装方式、LOOCHAT_HOME 与 Core .env 连接边界,以及 apps/workbench/packages/daemon/src/adapters/loopx/proxy.ts 在上游断开时返回 502 与 loopx_core_unavailable;其中第 188 / 443 行的卸载作用域描述超出了 apps/workbench/install.sh#L51-L64 的实际保护。
  2. Private Lark 历史恢复与防误触发更新(docs/product/releases/v2.4.0.md#L203-L207、#L458-L462):对应 loopx/extensions/lark/private_conversations.py 中 report_private_recall 与 _reconcile_historical_answer_images 流程,测试覆盖率与文档一致。
  3. 分发边界说明(docs/product/releases/v2.4.0.md#L275、#L513):packages/loopx-core/prepare.py#L15-L33 与 packages/loopx-core/pyproject.toml#L6 构建 loopx-core 时显式剔除 Chat 与 Web 资源,而 pyproject.toml#L6,L83 定义的完整 loopx 才包含 web/chat/*。

对主干的风险 / Risks

  • 高概率操作风险:两处 P2 文案直接面向安装/卸载与选包操作者,若不修正即合入主干,用户按文档清理错误指向的 LOOCHAT_HOME 时可能遭遇无警告删除,或安装 loopx-core 后找不到内置 Chat。
  • 本地验证记录:
    • examples/release/release-readiness-doc-smoke.py(7 个 --surface 参数):PASS
    • loopx check --scan-path docs/product/releases/v2.4.0.md:公开边界检查 clean(0 errors, 0 warnings),PASS
    • scripts/check_rfc_bilingual.py --base 27eaeb1277 --head HEAD:PASS
    • loopx canary premerge --from-git-diff --git-diff-base 27eaeb127777378d1e95d98e478ccfa779d08873:17/17 执行检查通过(0 failures),PASS
    • node --test apps/workbench/packages/e2e/test/install.spec.mjs:11/11 PASS
    • pytest(文档、发布、文档 IO 5 个套件):54 passed, 2 skipped;test_rfc_bilingual.py 与 test_contributor_task_board.py:42 passed;test_lark_private_conversations.py 专项过滤:62 passed(512 deselected)与 4 passed(570 deselected);test_core_distribution.py -k "not wheel":1 passed, 47 skipped(实际 wheel 构建测试已跳过,记为部分验证)。
    • examples/docs-governance-smoke.py:7/8 项 PASS,check_rfc_status_index() 在不变基线 27eaeb1277 上已因 monorepo-distribution-split-v0.md/.zh-CN.md 存在日期日志标题(### Core discovery checkpoint — 2026-11-19)而失败(pre_existing_unrelated)。
    • 反事实复核(LOOCHAT_HOME 非 Workbench 目录 --dry-run vs --uninstall --dry-run;prepare_core_source() 清单检查):FAIL(复现上述 2 项 P2 偏差)。

我的整体评价 / Verdict

当前评估为 justified_increment,但两处中英文准确性缺陷导致 user_experience 为 regression(long_horizon 为 not_applicable,仅改文档不涉运行时状态)。视觉审阅结论:仅修改 Markdown 发布文档 docs/product/releases/v2.4.0.md,未涉及任何前端渲染视图、样式或截图界面(未验证范围:无(纯文档变更,无前端视觉渲染改动;真实宿主机 LooChat 端到端安装与在线飞书发帖由独立发布门禁覆盖))。文档增量本身体积克制且已通过全部发布结构、公开边界与双语 premerge 门禁,无需调整架构。请先修正 #L188/#L443 与 #L275/#L513 的两处 P2 中英文文案并复跑 release-readiness-doc-smoke.py 与 canary premerge。

English verdict: REQUEST_CHANGES. Fix the bilingual LooChat uninstall checkout boundary wording (#L188/#L443) and distinguish the full loopx wheel/sdist carrying packaged Core Chat from standalone loopx-core (#L275/#L513) in docs/product/releases/v2.4.0.md at 47054a35fa9a72e728be13e9828983968d830570.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant