Repository navigation
Keep quota replan recovery inside control-plane boundaries - #9037
loopx-agent wants to merge 1 commit into
Conversation
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, max)
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
动机 / Motivation
quota 恢复、scheduler 回读和 Turn 启动前必须复用原 GoalRef 的 replan 证据,过滤已退休实例的 ACK。主干在重新投影时从 control plane 反向调用公共 status,导致 Todo read-model smoke 失败。候选改走原控制面投影,入口注入原 assist loader。相同输入的四条重建路径保留同一 obligation,并通过原边界 smoke。本轮验证来源、恢复选择及投影契约。
改动思路 / Approach
过滤沿用既有 GoalRef 判定,replan projector 从控制面模块直取。quota 首次及重建复用同一个部分应用的 builder,scheduler 和 Turn 入口传入同一既有 loader。恢复原依赖方向,继续使用原 guard、runs、ACK、assist 证据和 settlement owner。用独立 File 和 SQLite 夹具对照主干与候选,沿原 should-run 回执和实际重建函数读回结论,并核对读操作前后回执日志。
具体改动 / Changes
精确 head a8337bffeb5d15d7e1b77887f378f49ebee861c5,diff base 453d4e349cb08b4dd3258c4bbaaed4b9a3b513c8,5 个文件 +27/-9。逐项复核 forward-read-model-boundary、original-ref-and-ack、retain-progress-review。验收约定
关键代码讲解
- 只在已有开放 replan 回执时调用 ACK 过滤,控制面直接复用原 replan projector 和既有 assist loader。源码
- 普通 quota 执行和 post-stall 重建传同一个 builder,保持 loader 一致。源码
- 实际 scheduler、Turn plan 和启动前读取均从原 receipt 出发。两种结算绑定的对照保留外部进度评审触发,读操作保持原日志。源码
- 真实 held heartbeat 重新投影使用原 Todo 和 replan 身份,复用原始回执。源码
对主干的风险 / Risks
主干在相同 safe-path 命令下失败,候选完整通过。四个原 CLI 负例与两组多入口 replan 对照通过。组合结算复验 65 项通过、10 项跳过。普通 quota 和 settled replay 的 70 项也通过。作者记录的主干维护性提示涉及本次未改动的函数。
语义与 CI 对齐
File 和 SQLite 原回执测试保留过滤、结论与后续写回。真实的调度和 Turn 决策入口保持当前 assist 触发,输入未接受跨 GoalRef 的退休 ACK。
我的整体评价 / Verdict
批准当前提交。依赖边界修复已经由原 smoke 建立,原 GoalRef 回执、活跃 assist 的 replan 证据及四条重建路径的连续性均已独立验证。
English verdict: APPROVE. The read-model boundary smoke passes at this exact head. Scoped File and SQLite receipt tests and four reconstructed caller decisions preserve the original active assist replan and reject retired ACKs.
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
a8337bf to
e5f7567
Compare
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
Problem
When quota recovery removes a retired Goal instance's acknowledgement, the control plane calls back into the public status facade. The Todo read-model boundary smoke rejects that dependency before the rest of its checks can run.
Change
Use the existing control-plane replan projector for recovery. The quota command and its post-stall rebuild share the same decision builder with the established progress-review loader. Scheduler follow-up and Turn plan/launch callers that can resume a receipt-bound replan pass that same loader. Recovery keeps the original GoalRef, open obligation and assist-review evidence.
Validation
_admitted_interaction_next_cli_actions. Additional file-explicit mypy reported the same 11 existing diagnostics on the original paired base and candidate.Final local validation