Repository navigation
Conversation
buildHTMLData marshaled iterations into DataJSON but the template never referenced it. Drop the field, the marshal, and the unused encoding/json import. Add regression coverage so it is not reintroduced. Fixes loop-eng#14
rune-oai
force-pushed
the
fix/14-remove-unused-datajson
branch
from
September 11, 2026 14:45
746f660 to
ef15105
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildHTMLDatamarshaled iterations intoDataJSON(template.JS), but the HTML template never referenced it. The client-side nav already uses server-rendered iteration divs and{{.Summary.TotalIterations}}.DataJSONfield, thejson.Marshalcall, and the now-unusedencoding/jsonimportFixes #14
Test plan
go test ./internal/exporter/ -count=1(CI)