Repository navigation
fix: throw InvalidSep45ChallengeException for malformed SEP-45 challe… - #848
Merged
Merged
Conversation
…nges. readChallengeAuthorizationEntries, and so verifyChallengeAuthorizationEntries, let IllegalArgumentException and NullPointerException escape for input a client can send: an unknown XDR enum value or a string that isn't base64 (#834), an SCV_MAP argument whose map is absent, and an argument value that should be a string but isn't. They now throw the documented InvalidSep45ChallengeException, so a server can answer them with 400 instead of 500.
overcat
enabled auto-merge (squash)
November 20, 2026 10:02
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
============================================
- Coverage 83.68% 83.66% -0.03%
- Complexity 1740 1743 +3
============================================
Files 234 234
Lines 6241 6244 +3
Branches 713 713
============================================
+ Hits 5223 5224 +1
- Misses 627 629 +2
Partials 391 391
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nges.
Fixes #834