Repository navigation
fix: keep the fee and signatures of a V0 transaction when fee-bumping… - #846
Merged
Merged
Conversation
… it. createWithBaseFee rebuilt a V0 inner transaction with TransactionBuilder, passing its total fee as the base fee, so a transaction with more than one operation got a larger fee and its copied signatures no longer verified. A V0 transaction without time bounds threw IllegalStateException, and createWithFee didn't convert the inner transaction at all, so hash(), sign(KeyPair) and toEnvelopeXdrBase64() threw NullPointerException. Both factories now build the V1 equivalent directly, the way stellar-core converts a V0 envelope it receives.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
============================================
+ Coverage 83.65% 83.68% +0.02%
- Complexity 1738 1740 +2
============================================
Files 234 234
Lines 6242 6240 -2
Branches 714 713 -1
============================================
Hits 5222 5222
+ Misses 629 627 -2
Partials 391 391
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… it.
createWithBaseFee rebuilt a V0 inner transaction with TransactionBuilder, passing its total fee as the base fee, so a transaction with more than one operation got a larger fee and its copied signatures no longer verified. A V0 transaction without time bounds threw IllegalStateException, and createWithFee didn't convert the inner transaction at all, so hash(), sign(KeyPair) and toEnvelopeXdrBase64() threw NullPointerException. Both factories now build the V1 equivalent directly, the way stellar-core converts a V0 envelope it receives.