Skip to content

fix: keep the fee and signatures of a V0 transaction when fee-bumping… - #846

Merged
overcat merged 1 commit into
masterfrom
fix/v0-fee-bump
Nov 20, 2026
Merged

overcat merged 1 commit into
masterfrom
fix/v0-fee-bump

Conversation

@overcat

@overcat overcat commented Nov 20, 2026

Copy link
Copy Markdown
Member

… it.

createWithBaseFee rebuilt a V0 inner transaction with TransactionBuilder, passing its total fee as the base fee, so a transaction with more than one operation got a larger fee and its copied signatures no longer verified. A V0 transaction without time bounds threw IllegalStateException, and createWithFee didn't convert the inner transaction at all, so hash(), sign(KeyPair) and toEnvelopeXdrBase64() threw NullPointerException. Both factories now build the V1 equivalent directly, the way stellar-core converts a V0 envelope it receives.

… it.

createWithBaseFee rebuilt a V0 inner transaction with
TransactionBuilder, passing its total fee as the base fee, so a
transaction with more than one operation got a larger fee and its copied
signatures no longer verified. A V0 transaction without time bounds
threw IllegalStateException, and createWithFee didn't convert the inner
transaction at all, so hash(), sign(KeyPair) and toEnvelopeXdrBase64()
threw NullPointerException. Both factories now build the V1 equivalent
directly, the way stellar-core converts a V0 envelope it receives.
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.68%. Comparing base (d093810) to head (2bf78ae).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #846      +/-   ##
============================================
+ Coverage     83.65%   83.68%   +0.02%     
- Complexity     1738     1740       +2     
============================================
  Files           234      234              
  Lines          6242     6240       -2     
  Branches        714      713       -1     
============================================
  Hits           5222     5222              
+ Misses          629      627       -2     
  Partials        391      391              
Files with missing lines Coverage Δ
.../main/java/org/stellar/sdk/FeeBumpTransaction.java 88.15% <100.00%> (-0.45%) ⬇️
src/main/java/org/stellar/sdk/Transaction.java 93.78% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@overcat
overcat merged commit ec691a0 into master Nov 20, 2026
9 checks passed
@overcat
overcat deleted the fix/v0-fee-bump branch November 20, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant