Repository navigation
docs(specs): define the attested-data format X and GitHub pin - #112
Conversation
REQ-COMMON-18 has a profile with attestations fix their format, but the X and GitHub profiles only named "the pinned attestation format". The bytes lived in four implementations that agree by fixture alone. Section 4.1 now fixes the 48-byte header, the direction blocks, the SHA-256 range commitment and the EIP-191 notary signature, as the contracts verify them. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The X token-session text called every unrevealed byte charset-constrained. The circuit opens and constrains only the bearer range (REQ-PLAT-30); the status line, headers, scope and token_type stay behind commitments that nothing opens. Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
The direction-block table listed fields once, so an encoder could read it as one array per field. State that each range and each commitment is written whole, count times. Split REQ-PLAT-65's last sentence into one requirement each, and drop a sentence that restated "opens only the bearer range". Assisted-by: Claude Opus 5.5 Signed-off-by: xgreenx <xgreenx9999@gmail.com>
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://specs-attested-data-format.previews.lib.id, https://specs-attested-data-format-libid.grounded-systems.workers.dev (commit eca3a55)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Wondertan
left a comment
There was a problem hiding this comment.
Reviewed at 809c042. No blocking findings.
The byte layout matches the Rust encoder, browser decoder, and Solidity verifier. The 246-byte conformance vector matches the existing cross-language fixture, including its authority hash and digest. The signing construction agrees with EIP-191.
Two non-blocking follow-ups:
- Fix trailing-dot normalization in libid-rs
AttestedData::authority_id_of. It currently lowercases but preserves a trailing dot, soapi.x.com.produces an authority ID the verifier rejects. Keep the specification's canonicalization rule. - Consider adding a complete signature vector: the EIP-191 signed hash, signature, and expected signer. That would extend the existing encoding vector to cover cross-language signing and recovery.
The Notary Service's structural checks are compatible with its profile-agnostic role: decoding the attestation format is distinct from interpreting platform-specific evidence.
Checks: Markdown/theme tests and git diff --check pass. Spec lint is unchanged from the base: 79 existing errors and 99 warnings.
…ormat Signed-off-by: xgreenx <xgreenx9999@gmail.com> # Conflicts: # specs/platform-ceremonies.md
Since hidden identities the X and GitHub circuits open the id and handle commitments as well as both bearers (REQ-PLAT-32D, REQ-PLAT-52C). The conformance vector's sent direction keeps the identity-request layout; its received direction no longer matches an identity response. Signed-off-by: xgreenx <xgreenx9999@gmail.com>
|
Merged main 2e039e8 (0eb9086). Since hidden identities, the circuit opens the id and handle commitments too, so eca3a55 updates §4.1 ( |
REQ-COMMON-18 requires a profile with attestations to fix its attestation format. The X and GitHub profiles only named "the pinned attestation format".
Changes
specs/platform-ceremonies.md:797): the 48-byte header, the direction-block encoding, theSHA-256(plaintext || 16-byte blinder)commitment and the EIP-191 secp256k1 signature. The X and GitHub circuits open four commitments: both bearers, and the id and handle (REQ-PLAT-32D, REQ-PLAT-52C).:877-930): encoding, field values, commitment construction, signing, recovery, and shape rejection.:2007): a 246-byte conformance vector with its digest, plus negative cases.Verified
lint_spec.py specs/*.md: 108 errors on main and on this branch.CeremonyAttestation.sol,NotaryService.sol:119-128, libid-rsattestation.rsand TSdecode.ts.cast keccakreproduces the digest0x48162f05…95936.lib.nr:39-56, 16-byte blinder).Not verified / known issues
attestation.rs:169and libid-contractsCeremonyAttestation.t.sol:15still call the vector X identity-shaped.