Repository navigation
Move to Go 1.26.10 and x/net v0.60.0 to clear govulncheck findings - #50
Merged
Merged
Conversation
govulncheck reported 9 reachable vulnerabilities in net/http, net/textproto and crypto/tls (fixed in go1.26.9) and in x/net's HTTP/2 code (fixed in v0.60.0). Bump the go directive, toolchain and the Docker builder images to 1.26 so the shipped binaries pick up the fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vulnerability Scan job added in #35 fails on
main. govulncheck traces 9 vulnerabilities to code shimmy actually runs (the HTTP server, the muEd handlers andcmd.run).net/http,net/textproto,crypto/tls(GO-2026-6603, 6605, 6607, 6608, 6610–6613, 6617)golang.org/x/netHTTP/2 (6 of the above)The Go 1.25 line has no fix for these, so this moves shimmy to Go 1.26.
Changes
go.mod:go 1.26.0,toolchain go1.26.10andgolang.org/x/net v0.60.0.go mod tidyalso brought in the matching x/sync, x/sys and x/text bumps.Dockerfile: the builder and test-sandbox stages now usegolang:1.26, so the shipped image is built with the fixed toolchain. CI'ssetup-gosteps already read the version fromgo.mod.Testing
On go1.26.10,
go build ./...,go vet ./...andgo test ./...all pass, andgovulncheck ./...reports "No vulnerabilities found."Once this is merged, shimmy v0.0.9 gets released from
main.🤖 Generated with Claude Code