Skip to content

WIP: Kita Html v5.0.0 - #468

Open
arthurfiorette wants to merge 147 commits into
masterfrom
next
Open

arthurfiorette wants to merge 147 commits into
masterfrom
next

Conversation

@arthurfiorette

Copy link
Copy Markdown
Member

This pull request introduces significant improvements to CI/CD workflows, documentation tooling, and package configuration. The CI pipeline now supports broader Node.js versions and operating systems, adds a dedicated docs deployment job, and optimizes build caching. Documentation quality is enhanced with new agent and skill files enforcing strict writing and structuring conventions. Several package changesets address test coverage, CLI reliability, and plugin improvements.

CI/CD Workflow Enhancements

  • Expanded CI matrix to cover multiple Node.js LTS versions and all major OSes, improving test coverage and reliability (.github/workflows/ci.yml).
  • Added a dedicated deploy-docs job for automatic documentation deployment to GitHub Pages on master and next branches (.github/workflows/ci.yml).
  • Introduced turbo build caching to CI and release workflows for faster builds (.github/workflows/ci.yml, .github/workflows/release.yml) [1] [2].
  • Removed the unused CodeQL workflow, streamlining CI configuration (.github/workflows/codeql.yml).

Documentation Tooling and Standards

  • Added a new docs-writer agent and two skill files (information-mapping, rspress-writing) to enforce structured writing and Rspress conventions for documentation (.claude/agents/docs-writer/CLAUDE.md, .claude/skills/information-mapping/SKILL.md, .claude/skills/rspress-writing/SKILL.md, .claude/skills/rspress-writing/style-examples.md) [1] [2] [3] [4].

Package Configuration Improvements

  • Updated .changeset/config.json to ignore additional example and docs packages in dependency updates, reducing unnecessary changes.

Package Changesets

  • Broadened and improved test suite for @kitajs/html, removed deprecated @kitajs/html/register, and initiated a major overhaul (.changeset/slimy-wolves-buy.md, .changeset/stale-shrimps-spend.md, .changeset/warm-seas-kiss.md) [1] [2] [3].
  • Improved CLI reliability, XSS detection, and multiline TSServer message support in @kitajs/ts-html-plugin (.changeset/metal-hairs-juggle.md, .changeset/metal-corners-type.md, .changeset/hip-trams-roll.md) [1] [2] [3].

arthurfiorette and others added 11 commits October 13, 2026 12:46
…eprecate ts-html-plugin (#530)

* feat: add @kitajs/html-cli with kita-html check for TypeScript 7.1+

Adds packages/cli, an oclif CLI whose `kita-html check` command ports the
ts-html-plugin XSS detection to the TypeScript 7.1 typescript/sync API, with
pretty, tsc, json and github output formats and solution-style tsconfig
expansion.

Deprecates @kitajs/ts-html-plugin (package.json `deprecated` field, README,
help text and an xss-scan notice). xss-scan now points to kita-html check on
TypeScript 7, keeps findings that share a position across files and no longer
truncates piped output.

Docs: the CLI page moves to guide/xss/cli-scanner, the deprecated plugin to
guide/xss/ts-html-plugin, and every page recommends TypeScript 7.1 with
kita-html check.

* fix: address review findings for kita-html check and ts-html-plugin

- Check every member of children unions without a direct string member
  (children?: string[] was trusted), guard recursive types against infinite
  recursion, and read type arguments through the checker in the plugin so
  arrays inside recursive aliases are checked (both packages)
- Allow the same solution tsconfig to be passed twice or after one of its
  projects
- Print github format log lines that the setup-node tsc problem matcher
  ignores, so findings are not annotated twice
- Compare the @kitajs/html root case-insensitively on Windows and macOS and
  print the unresolved @kitajs/html notice once per run
- Docs and metadata: TypeScript 6 (not 5) for the deprecated plugin, homepage
  links, review wording fixes

* feat(cli): annotate pull requests by default in GitHub Actions, fix safe attribute checks

- Inside GitHub Actions, kita-html check without --format prints annotations
  plus the colored pretty output, with headers the setup-node tsc problem
  matcher ignores. An explicit --format keeps the previous output
- Treat safe={true} like a bare safe attribute
- Only report TS88604 when every child of a safe element is already safe,
  and report TS88602 instead of hiding it behind TS88604
- Run CLI tests in-process with @oclif/test and keep three spawned smoke
  tests: each spawned oclif process took 18-36 s on Windows runners, which
  made the suite time out

* fix(cli): skip oclif's Windows shell detection, address Copilot review

- oclif spawned PowerShell with a WMI query on every run when SHELL is unset
  on Windows (only autocomplete uses the result). This made each run take
  18-55 s on Windows runners and timed out the CLI tests. The bin now sets
  SHELL for every command except autocomplete
- FORCE_COLOR follows Node.js: empty forces colors, 0 or false disables them
- Homepage install command installs the CLI and typescript@next as dev
  dependencies, like getting started
- Grammar fix in the ts-html-plugin README

* test(ts-html-plugin): raise the tsserver test timeout for loaded Windows runners

* feat: make TypeScript 7.1 the workspace default and let --format take several formats

- Default catalog typescript is the latest next nightly allowed by
  minimumReleaseAge (7.1.0-dev.20261012.1). A ts6 catalog remains only for
  code that needs the TypeScript 6 JavaScript API: ts-html-plugin, the docs
  site (twoslash, TypeDoc) and the root (prettier-plugin-organize-imports)
- Express and Fastify plugins: optional peer moves from the deprecated
  @kitajs/ts-html-plugin to @kitajs/html-cli; examples run kita-html check
- --format accepts several formats (comma separated or repeated), prints each
  once in order and defaults to pretty,github inside GitHub Actions. The
  github format prints only annotations; json must be used alone
- The JSON Schema is generated from src/reporters/json-report.ts at build
  time with ts-json-schema-generator and exported as
  @kitajs/html-cli/check-report.schema.json. The report drops its version
  field
* code

* Release Suspense state on HEAD requests and drop Nitro build output

* Fix review findings, align with kita-html check, and document H3 and Nitro

* Upgrade h3 to 2.0.8 and nitro to 3.0.261103-rc to fix known vulnerabilities
@mira-arthur

mira-arthur Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Mira PR Walkthrough

This large WIP PR prepares Kita Html v5.0.0. It restructures @kitajs/html sources (new src/ layout, helpers, suspense, jsx runtimes), introduces a new @kitajs/cli XSS analyzer package and new Express, H3 and Nitro plugins, and reworks the Fastify and ts-html-plugin packages. It also adds a full Rspress docs site, examples, benchmarks updates, Turbo-based builds, CI/release changes, many changesets, and a large amount of agent/skill tooling. The PR description covers only a small part of the actual change set.

Confidence: 2/5   ◉◉○○○   WIP - needs significant review
  • This is a WIP, very large PR (major version, new packages, breaking removals, rewritten runtime and CI). Its description doesn't match the real scope, and it includes files that look accidentally committed (.serena local config, benchmarks/results.txt).

Blast Radius — 2 dependent repositories, 5 total references

arthurfiorette/place — 2 references
kitajs/kitajs — 3 references

435 files reviewed · 5 comments (🛑 4 blockers, ⚠️ 1 warning)


Comment @miracodeai help to get the list of available commands and usage tips.

Co-authored-by: arthurfiorette <47537704+arthurfiorette@users.noreply.github.com>

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This PR has blocking security issues: known vulnerabilities in the vitest, nitro, h3, and express catalog dependencies (packages/html/package.json, packages/nitro-html-plugin/package.json, packages/h3-html-pl

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

Comment thread package.json
"change": "changeset",
"ci-publish": "pnpm publish -r --access public && changeset tag",
"ci-version": "changeset version && pnpm install --no-frozen-lockfile",
"bench": "turbo run benchmark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in turbo@2.9.6

OSV.dev reports 2 known vulnerabilities affecting turbo@2.9.6, introduced by this PR:

  • GHSA-3qcw-2rhx-2726 low: Turbo: Unexpected local code execution during Yarn Berry detection — fixed in 2.9.14
  • GHSA-hcf7-66rw-9f5r moderate: Turbo: Login callback CSRF/session fixation — fixed in 2.9.14

Upgrade to 2.9.14 or later.


Prompt for AI Agents
In package.json, upgrade the dependency turbo from 2.9.6 to a non-vulnerable version (2.9.14). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

if run_id not in result:
result[run_id] = {"feedback": fb, "outputs": []}

return result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Embedded JSON not escaped for <script> context (stored XSS in viewer)

generate_html injects json.dumps(embedded) straight into an inline <script> block. json.dumps does not escape </script> or <!--. The payload includes the full text of every output file (embed_file reads .html, .md, .js and other text outputs, plus prompts and grading evidence). Model-generated or untrusted output containing </script><script>... closes the script element and runs attacker JavaScript on the viewer origin (localhost:3117). That origin can read and write /api/feedback. Eval outputs are exactly the kind of untrusted content this tool reviews, so this is realistic.

Suggested change
return result
# Escape sequences that can terminate or confuse an inline <script> block
data_json = (
data_json.replace("<", "\\u003c")
.replace(">", "\\u003e")
.replace("&", "\\u0026")
.replace("\u2028", "\\u2028")
.replace("\u2029", "\\u2029")
)
return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Prompt for AI Agents
In generate_review.py generate_html(), after computing data_json via json.dumps, escape '<', '>', '&', U+2028 and U+2029 as \uXXXX sequences before substituting into the template, so embedded file contents cannot close the inline <script> tag.

Apply this code change:

    # Escape sequences that can terminate or confuse an inline <script> block
    data_json = (
        data_json.replace("<", "\\u003c")
        .replace(">", "\\u003e")
        .replace("&", "\\u0026")
        .replace("\u2028", "\\u2028")
        .replace("\u2029", "\\u2029")
    )
    return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

Comment thread benchmarks/runner/package.json Outdated
"ghtml": "3.1.2",
"hono": "4.11.10",
"ghtml": "4.0.2",
"hono": "4.12.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in hono@4.12.18

OSV.dev reports 21 known vulnerabilities affecting hono@4.12.18, introduced by this PR:

  • GHSA-2gcr-mfcq-wcc3 moderate: Hono: app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths — fixed in 4.12.21
  • GHSA-3hrh-pfw6-9m5x moderate: Hono: Cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection — fixed in 4.12.21
  • GHSA-54fx-42gc-7vw4 moderate: Hono: Algorithmic Complexity DoS in Language Middleware — fixed in 4.12.34

…and 18 more — see the OSV links above.

Upgrade to 4.12.21 or later.


Prompt for AI Agents
In benchmarks/runner/package.json, upgrade the dependency hono from 4.12.18 to a non-vulnerable version (4.12.21, 4.12.25, 4.12.27, 4.12.34, 4.13.11, 4.13.5, 4.13.7). Update any associated lockfile entries.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

},
"engines": {
"node": ">=12"
"node": ">=12.17"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration
⚠️ Warning

engines.node is far below what the shipped code actually needs

engines.node is >=12.17, but the published runtime imports node:async_hooks (top-level in suspense.ts, so every Suspense user loads it), node:stream, and node:timers/promises (error-boundary.ts, Node 15+). The node: specifier in require is only supported from Node 14.18/16. Node 12 and 14 consumers will hit Cannot find module 'node:...' at import time rather than being warned by their package manager. The rest of the repo requires Node 24 and the adapter packages need modern Node. Raise the range to the oldest version the code really supports, for example >=16.14 or whatever you actually test in CI, and keep it consistent across packages.

Suggested change
"node": ">=12.17"
"node": ">=16.14"

Prompt for AI Agents
In packages/html/package.json, update `engines.node` from `>=12.17` to the minimum Node version that supports the `node:` import scheme and `node:timers/promises` used by src/suspense.ts and src/error-boundary.ts (at least >=16.14, or the oldest version CI actually tests), and check that the other packages' engines are consistent.

Apply this code change:

    "node": ">=16.14"

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

Co-authored-by: arthurfiorette <47537704+arthurfiorette@users.noreply.github.com>

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

The changelogs for @kitajs/html and the fastify and express plugins each repeat a version heading, with the release notes split across the two sections: ## 5.0.0-next.2 in packages/html/CHANGELOG.md (line 15), ## 5.0.0-next.3 in packages/fastify-html-plugin/CHANGELO

Key Issues

Issue Location
🔴 Three changelogs (html, fastify, express) each contain the same version heading twice, with the release notes split across the two sections. The ledger and package.json show a single release per version. packages/html/CHANGELOG.md:15

- `@kitajs/html` relays every Suspense boundary failure under an async root to the
response stream instead of raising unhandled rejections after the first one.

## 5.0.0-next.2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug
⚠️ Warning

Duplicate ## 5.0.0-next.2 heading in @kitajs/html changelog

The file has two ## 5.0.0-next.2 sections, at lines 3 and 15. The first holds the H3/Nitro patch note. The second holds the request-ID, agent-skill, suspense-ID and rid entries. .changeset/ledger.yaml records a single @kitajs/html@5.0.0-next.2 release with all of these intents together, and packages/html/package.json is bumped to 5.0.0-next.2 once. The changelog should therefore have one section. As written, the same version appears twice with different content, and tools that parse or link to changelog headings (GitHub release notes, docs, changelog readers) will pick one block and lose the other. The cause looks like two release-plan runs that both wrote the same version, so the bump was not recalculated after the first one. Merge the two blocks into one 5.0.0-next.2 section, with Minor Changes first and then Patch Changes.


Prompt for AI Agents
In packages/html/CHANGELOG.md, the heading `## 5.0.0-next.2` appears twice (lines 3 and 15). Merge the two sections into a single `## 5.0.0-next.2` section, with `### Minor Changes` (request-ID propagation, pnpm agent skill) followed by one combined `### Patch Changes` list containing the H3/Nitro entry and the existing patch entries. Remove the duplicate heading.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

- Release Suspense state immediately for HEAD requests instead of waiting for pending
boundaries

## 5.0.0-next.3

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug
⚠️ Warning

Duplicate ## 5.0.0-next.3 heading in fastify plugin changelog

The file has two ## 5.0.0-next.3 sections, at lines 3 and 10. The first holds the HEAD-request Suspense release note. The second holds the @kitajs/html-cli peer-dependency change, the request-ID propagation and the async-root note. .changeset/ledger.yaml has one @kitajs/fastify-html-plugin@5.0.0-next.3 entry listing all four intents, and package.json is bumped to 5.0.0-next.3 once. Two sections with the same version make the changelog ambiguous and break anything that looks sections up by version. Merge them into a single section.


Prompt for AI Agents
In packages/fastify-html-plugin/CHANGELOG.md, the heading `## 5.0.0-next.3` appears twice (lines 3 and 10). Merge them into one `## 5.0.0-next.3` section with Major Changes, Minor Changes and a single Patch Changes list that includes the HEAD-request Suspense release entry and the async-root replacement entry. Delete the duplicate heading.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

- Release Suspense state immediately for HEAD requests instead of waiting for pending
boundaries

## 5.0.0-next.1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug
⚠️ Warning

Duplicate ## 5.0.0-next.1 heading in express plugin changelog

The file has two ## 5.0.0-next.1 sections, at lines 3 and 10. The first holds the HEAD-request Suspense note. The second holds the @kitajs/html-cli peer-dependency change, the request-ID propagation and the async-root note. .changeset/ledger.yaml has one @kitajs/express-html-plugin@5.0.0-next.1 entry covering all intents, and package.json is bumped to 5.0.0-next.1 once. Merge the two blocks into one section so the version heading is unique.


Prompt for AI Agents
In packages/express-html-plugin/CHANGELOG.md, the heading `## 5.0.0-next.1` appears twice (lines 3 and 10). Merge the two sections into one `## 5.0.0-next.1` section containing Major Changes, Minor Changes and one combined Patch Changes list, including the HEAD-request Suspense release entry. Remove the duplicate heading.

Not useful? Reply @mira-arthur reject to dismiss this suggestion.

* chore(bench): compare only jsx runtimes on output that is consumed and escaped

- Consume the rendered html with Buffer.from so V8 rope flattening is measured
- Await sample formatting before mitata starts and move React equality to pnpm test
- Assert every runner matches React, with names that need escaping
- Warm up the profile script and record heap profiles
- Remove TypedHtml, vHtml, Jsxte, CommonTags, Ghtml and HonoHtml
- Add benchmarks/stress with one scenario per Kita Html feature

* perf(html): render with fewer intermediate strings and fix children and style bugs

- Cache tag, attribute and style property name fragments
- Read element props in a single pass and resolve async children with one promise
- Join nested children recursively without mutating or spreading arrays
- Render non native thenables, keep css custom properties as written and add a leading
  hyphen to vendor prefixed style keys (#537)
- Move name helpers to helpers.ts and stop exporting isUpper and toKebabCase

* delete plan

* chore: share prettier version through the pnpm catalog
@codecov-commenter

codecov-commenter commented Nov 16, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.07692% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (d22507f) to head (3b2b236).

Files with missing lines Patch % Lines
packages/cli/src/cli/commands/check.ts 74.28% 7 Missing and 2 partials ⚠️
packages/cli/src/analyzer/assignments.ts 82.50% 6 Missing and 1 partial ⚠️
packages/cli/src/analyzer/element.ts 96.20% 3 Missing ⚠️
packages/cli/src/analyzer/kita-types.ts 88.46% 2 Missing and 1 partial ⚠️
packages/cli/src/analyzer/syntax.ts 93.61% 3 Missing ⚠️
packages/cli/src/check.ts 97.82% 3 Missing ⚠️
packages/cli/src/analyzer/safety.ts 98.40% 2 Missing ⚠️
packages/cli/src/analyzer/walk.ts 92.30% 1 Missing ⚠️
packages/cli/src/typescript.ts 96.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##            master     #468       +/-   ##
============================================
- Coverage   100.00%   75.78%   -24.22%     
============================================
  Files            4       45       +41     
  Lines          434     1883     +1449     
  Branches         0      645      +645     
============================================
+ Hits           434     1427      +993     
- Misses           0      357      +357     
- Partials         0       99       +99     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This review flags five blocking security issues: known vulnerabilities in vitest@catalog (pack

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread package.json
"change": "changeset",
"ci-publish": "pnpm publish -r --access public && changeset tag",
"ci-version": "changeset version && pnpm install --no-frozen-lockfile",
"bench": "turbo run benchmark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in turbo@2.9.6

OSV.dev reports 2 known vulnerabilities affecting turbo@2.9.6, introduced by this PR:

  • GHSA-3qcw-2rhx-2726 low: Turbo: Unexpected local code execution during Yarn Berry detection — fixed in 2.9.14
  • GHSA-hcf7-66rw-9f5r moderate: Turbo: Login callback CSRF/session fixation — fixed in 2.9.14

Upgrade to 2.9.14 or later.


Prompt for AI Agents
In package.json, upgrade the dependency turbo from 2.9.6 to a non-vulnerable version (2.9.14). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.


data_json = json.dumps(embedded)

return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

JSON embedded in <script> without escaping </script> (XSS)

json.dumps(embedded) is spliced directly into an inline <script> block. Output files (text, html, svg and so on from eval runs, which are model-generated or untrusted) and prompts are included in that JSON. json.dumps does not escape </script> or <!--. A run output containing </script><script>... ends the script block and runs attacker-controlled JS in the viewer origin. That origin can POST to /api/feedback and read the page.

Suggested change
return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")
data_json = data_json.replace("<", "\\u003c").replace(">", "\\u003e").replace("&", "\\u0026")
return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Prompt for AI Agents
In generate_html in generate_review.py, escape '<', '>' and '&' in the JSON string as \u003c, \u003e and \u0026 before embedding it in the HTML template, so output content cannot close the script tag.

Apply this code change:

    data_json = data_json.replace("<", "\\u003c").replace(">", "\\u003e").replace("&", "\\u0026")
    return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Not useful? Reply @miracodeai reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread benchmarks/honojsx/package.json Outdated
"tslib": "^2.8.1",
"typescript": "^5.9.2"
"@typescript/native-preview": "catalog:",
"hono": "^4.12.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in hono@4.12.18

OSV.dev reports 26 known vulnerabilities affecting hono@4.12.18, introduced by this PR:

  • GHSA-2gcr-mfcq-wcc3 moderate: Hono: app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths — fixed in 4.12.21
  • GHSA-3gg2-335m-rxc6 low: Hono: css helper does not escape a closing tag split between the template and an interpolated value, allowing HTML injection — fixed in 4.13.16
  • GHSA-3hrh-pfw6-9m5x moderate: Hono: Cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection — fixed in 4.12.21

…and 23 more — see the OSV links above.

Upgrade to 4.12.21 or later.


Prompt for AI Agents
In benchmarks/honojsx/package.json, upgrade the dependency hono from 4.12.18 to a non-vulnerable version (4.12.21, 4.12.25, 4.12.27, 4.12.34, 4.13.11, 4.13.16, 4.13.5, 4.13.7). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Co-authored-by: arthurfiorette <47537704+arthurfiorette@users.noreply.github.com>

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This PR has blocking security issues: the Express stream-error handler in `packages/express-html-pl

Key Issues

Issue Location
🔴 Express stream-error handler writes the raw error message as text/html, which risks reflected XSS and information disclosure packages/express-html-plugin/src/html.ts:132
🔴 Docs deploy gate uses github.head_ref, so it doesn't deploy on pushes to next, and a PR from a branch named next could trigger a deploy .github/workflows/ci.yml:70

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread package.json
"change": "changeset",
"ci-publish": "pnpm publish -r --access public && changeset tag",
"ci-version": "changeset version && pnpm install --no-frozen-lockfile",
"bench": "turbo run benchmark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in turbo@2.9.6

OSV.dev reports 2 known vulnerabilities affecting turbo@2.9.6, introduced by this PR:

  • GHSA-3qcw-2rhx-2726 low: Turbo: Unexpected local code execution during Yarn Berry detection — fixed in 2.9.14
  • GHSA-hcf7-66rw-9f5r moderate: Turbo: Login callback CSRF/session fixation — fixed in 2.9.14

Upgrade to 2.9.14 or later.


Prompt for AI Agents
In package.json, upgrade the dependency turbo from 2.9.6 to a non-vulnerable version (2.9.14). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

return
}

response.status(500).end(error instanceof Error ? error.message : String(error))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Stream error message is written to the client as text/html

When a Suspense stream errors before headers are sent, the handler calls response.status(500).end(error.message). handleStreamHtml has already set Content-Type: text/html; charset=utf-8. The error message is therefore served as HTML unescaped, and it can include user-influenced text such as a failed lookup of a request value, which gives reflected XSS. It also leaks internal error details. Return a generic message with a non-HTML content type, or escape the text, and let the error be logged server-side. The Fastify plugin returns a JSON error instead.

Suggested change
response.status(500).end(error instanceof Error ? error.message : String(error))
response.status(500).type('text/plain; charset=utf-8').end('Internal Server Error')

Prompt for AI Agents
In packages/express-html-plugin/src/html.ts, in the stream 'error' handler where headers are not yet sent, stop writing error.message with the text/html content type. Set the response type to text/plain and send a generic 'Internal Server Error' body (or escape the message with escapeHtml).

Apply this code change:

response.status(500).type('text/plain; charset=utf-8').end('Internal Server Error')

Not useful? Reply @miracodeai reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread benchmarks/honojsx/package.json Outdated
"tslib": "^2.8.1",
"typescript": "^5.9.2"
"@typescript/native-preview": "catalog:",
"hono": "^4.12.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in hono@4.12.18

OSV.dev reports 26 known vulnerabilities affecting hono@4.12.18, introduced by this PR:

  • GHSA-2gcr-mfcq-wcc3 moderate: Hono: app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths — fixed in 4.12.21
  • GHSA-3gg2-335m-rxc6 low: Hono: css helper does not escape a closing tag split between the template and an interpolated value, allowing HTML injection — fixed in 4.13.16
  • GHSA-3hrh-pfw6-9m5x moderate: Hono: Cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection — fixed in 4.12.21

…and 23 more — see the OSV links above.

Upgrade to 4.12.21 or later.


Prompt for AI Agents
In benchmarks/honojsx/package.json, upgrade the dependency hono from 4.12.18 to a non-vulnerable version (4.12.21, 4.12.25, 4.12.27, 4.12.34, 4.13.11, 4.13.16, 4.13.5, 4.13.7). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread .github/workflows/ci.yml

deploy-docs:
needs: build
if: ${{ github.head_ref == 'next' || github.ref == 'refs/heads/master' }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration
⚠️ Warning

Docs deploy condition never true for pushes to next

github.head_ref is only populated on pull_request events, and the workflow's push trigger is limited to master. So github.head_ref == 'next' can only match a PR whose source branch is named next. That is not the 'deploy on master or next' behavior described in the PR, and it could deploy production docs from a PR build. Pushes to next neither trigger the workflow nor pass this condition. Use github.ref, and add next to the push.branches list.

Suggested change
if: ${{ github.head_ref == 'next' || github.ref == 'refs/heads/master' }}
if: ${{ github.ref == 'refs/heads/next' || github.ref == 'refs/heads/master' }}

Prompt for AI Agents
In .github/workflows/ci.yml, change the deploy-docs job `if` condition to use `github.ref == 'refs/heads/next' || github.ref == 'refs/heads/master'` instead of `github.head_ref == 'next'`, and add `next` to the `on.push.branches` list so pushes to next trigger the workflow.

Apply this code change:

if: ${{ github.ref == 'refs/heads/next' || github.ref == 'refs/heads/master' }}

Not useful? Reply @miracodeai reject to dismiss this suggestion.

}

function changelogSection(dir, version) {
const file = join(dir, 'CHANGELOG.md')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug
💡 Suggestion

join(dir, ...) runs before the !dir guard and throws on undefined

dirs.get(name) returns undefined for a published package that is not under packages/. join(undefined, 'CHANGELOG.md') is evaluated before the !dir check, so it throws a TypeError instead of falling back to the tag as release notes. That aborts release creation for every remaining package. The !dir guard on the next line is dead code. Check dir before calling join.

Suggested change
const file = join(dir, 'CHANGELOG.md')
if (!dir) return ''
const file = join(dir, 'CHANGELOG.md')
if (!existsSync(file)) return ''

Prompt for AI Agents
In .github/scripts/create-github-releases.mjs, function changelogSection: return '' immediately when `dir` is falsy before calling `join(dir, 'CHANGELOG.md')`, then check `existsSync(file)` separately.

Apply this code change:

  if (!dir) return ''

  const file = join(dir, 'CHANGELOG.md')
  if (!existsSync(file)) return ''

Not useful? Reply @miracodeai reject to dismiss this suggestion.

…ension (#542)

* fix: throw on function attribute values instead of rendering unescaped source

* feat: add @kitajs/html/custom-elements type extension

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This PR has blocking security findings for known vulnerabilities in vitest (packages/html

Key Issues

Issue Location
🔴 Embedded JSON in the eval viewer can terminate the script tag via </script> in output files .agents/skills/skill-creator/eval-viewer/generate_review.py:281
🔴 parse_skill_md yields an empty description for plain multi-line YAML frontmatter .agents/skills/skill-creator/scripts/utils.py:33

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread package.json
"change": "changeset",
"ci-publish": "pnpm publish -r --access public && changeset tag",
"ci-version": "changeset version && pnpm install --no-frozen-lockfile",
"bench": "turbo run benchmark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in turbo@2.9.6

OSV.dev reports 2 known vulnerabilities affecting turbo@2.9.6, introduced by this PR:

  • GHSA-3qcw-2rhx-2726 low: Turbo: Unexpected local code execution during Yarn Berry detection — fixed in 2.9.14
  • GHSA-hcf7-66rw-9f5r moderate: Turbo: Login callback CSRF/session fixation — fixed in 2.9.14

Upgrade to 2.9.14 or later.


Prompt for AI Agents
In package.json, upgrade the dependency turbo from 2.9.6 to a non-vulnerable version (2.9.14). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread benchmarks/honojsx/package.json Outdated
"tslib": "^2.8.1",
"typescript": "^5.9.2"
"@typescript/native-preview": "catalog:",
"hono": "^4.12.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in hono@4.12.18

OSV.dev reports 26 known vulnerabilities affecting hono@4.12.18, introduced by this PR:

  • GHSA-2gcr-mfcq-wcc3 moderate: Hono: app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths — fixed in 4.12.21
  • GHSA-3gg2-335m-rxc6 low: Hono: css helper does not escape a closing tag split between the template and an interpolated value, allowing HTML injection — fixed in 4.13.16
  • GHSA-3hrh-pfw6-9m5x moderate: Hono: Cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection — fixed in 4.12.21

…and 23 more — see the OSV links above.

Upgrade to 4.12.21 or later.


Prompt for AI Agents
In benchmarks/honojsx/package.json, upgrade the dependency hono from 4.12.18 to a non-vulnerable version (4.12.21, 4.12.25, 4.12.27, 4.12.34, 4.13.11, 4.13.16, 4.13.5, 4.13.7). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.


data_json = json.dumps(embedded)

return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Embedded JSON can break out of the <script> block

json.dumps(embedded) is inlined into a <script> in viewer.html. The payload includes the full text of every output file (.html, .md, etc.) and the grading and benchmark data. json.dumps does not escape </script> or <!--. Any output that contains </script> ends the script early. That breaks the viewer, and the rest of the content is then parsed as HTML, which allows script injection from untrusted model output. Escape <, > and & (and U+2028/2029) in the serialized JSON before inlining it.

Suggested change
return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")
data_json = data_json.replace("<", "\\u003c").replace(">", "\\u003e").replace("&", "\\u0026").replace("\u2028", "\\u2028").replace("\u2029", "\\u2029")
return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Prompt for AI Agents
In .agents/skills/skill-creator/eval-viewer/generate_review.py, in generate_html, escape '<', '>', '&', U+2028 and U+2029 in data_json as \uXXXX sequences before substituting it into the template, so output file contents containing </script> cannot terminate the script tag.

Apply this code change:

    data_json = data_json.replace("<", "\\u003c").replace(">", "\\u003e").replace("&", "\\u0026").replace("\u2028", "\\u2028").replace("\u2029", "\\u2029")
    return template.replace("/*__EMBEDDED_DATA__*/", f"const EMBEDDED_DATA = {data_json};")

Not useful? Reply @miracodeai reject to dismiss this suggestion.

if line.startswith("name:"):
name = line[len("name:"):].strip().strip('"').strip("'")
elif line.startswith("description:"):
value = line[len("description:"):].strip()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug
⚠️ Warning

parse_skill_md returns empty description for plain multi-line YAML

When description: has no inline value and the text sits on the following indented lines, value is ''. The multi-line branch only handles the >, |, >- and |- indicators, so the description ends up empty. The skill-creator SKILL.md itself, and rspress-writing and others, use this prettier-formatted style. run_loop.py and run_eval.py would then optimize and test an empty description. Treat an empty value as a continuation too.

Suggested change
value = line[len("description:"):].strip()
value = line[len("description:"):].strip()
if value == "":
value = ">"

Prompt for AI Agents
In .agents/skills/skill-creator/scripts/utils.py parse_skill_md, treat an empty inline value after 'description:' as a folded multi-line block (same as '>') so indented continuation lines on following lines are joined into the description.

Apply this code change:

            value = line[len("description:"):].strip()
            if value == "":
                value = ">"

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Co-authored-by: arthurfiorette <47537704+arthurfiorette@users.noreply.github.com>

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This PR has blocking security issues from known vulnerabilities in vitest (packages/html/package.json

Key Issues

Issue Location
🔴 The docs deploy job's github.head_ref == 'next' check only matches PRs from a branch named next, and CI is not triggered by pushes to next. Docs will not deploy from next pushes, and a PR from next could publish to production Pages. .github/workflows/ci.yml:69

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread package.json
"change": "changeset",
"ci-publish": "pnpm publish -r --access public && changeset tag",
"ci-version": "changeset version && pnpm install --no-frozen-lockfile",
"bench": "turbo run benchmark",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in turbo@2.9.6

OSV.dev reports 2 known vulnerabilities affecting turbo@2.9.6, introduced by this PR:

  • GHSA-3qcw-2rhx-2726 low: Turbo: Unexpected local code execution during Yarn Berry detection — fixed in 2.9.14
  • GHSA-hcf7-66rw-9f5r moderate: Turbo: Login callback CSRF/session fixation — fixed in 2.9.14

Upgrade to 2.9.14 or later.


Prompt for AI Agents
In package.json, upgrade the dependency turbo from 2.9.6 to a non-vulnerable version (2.9.14). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread benchmarks/honojsx/package.json Outdated
"tslib": "^2.8.1",
"typescript": "^5.9.2"
"@typescript/native-preview": "catalog:",
"hono": "^4.12.18",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in hono@4.12.18

OSV.dev reports 26 known vulnerabilities affecting hono@4.12.18, introduced by this PR:

  • GHSA-2gcr-mfcq-wcc3 moderate: Hono: app.mount() strips mount prefix using undecoded path, causing incorrect routing for percent-encoded paths — fixed in 4.12.21
  • GHSA-3gg2-335m-rxc6 low: Hono: css helper does not escape a closing tag split between the template and an interpolated value, allowing HTML injection — fixed in 4.13.16
  • GHSA-3hrh-pfw6-9m5x moderate: Hono: Cookie helper does not sanitize sameSite and priority, allowing Set-Cookie injection — fixed in 4.12.21

…and 23 more — see the OSV links above.

Upgrade to 4.12.21 or later.


Prompt for AI Agents
In benchmarks/honojsx/package.json, upgrade the dependency hono from 4.12.18 to a non-vulnerable version (4.12.21, 4.12.25, 4.12.27, 4.12.34, 4.13.11, 4.13.16, 4.13.5, 4.13.7). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

Comment thread .github/workflows/ci.yml
token: ${{ secrets.CODECOV_TOKEN }}

deploy-docs:
needs: build

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration
⚠️ Warning

Docs deploy condition does not match the intended next branch deploy

The deploy-docs job is gated on github.head_ref == 'next' || github.ref == 'refs/heads/master'. github.head_ref is only set on pull_request events, and this workflow only triggers on push to master, pull_request and manual dispatch. A push to next never runs this workflow. A pull request whose source branch is named next does pass the condition, so it deploys an unmerged PR build to the production GitHub Pages environment. The PR description says docs deploy on master or next pushes. The docs editLink and release workflow also treat next as a first-class branch.

Suggested change
needs: build
if: ${{ github.event_name != 'pull_request' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/next') }}

Prompt for AI Agents
In .github/workflows/ci.yml, fix the `deploy-docs` job `if` condition (around line 69) so it only runs on push or dispatch events for master or next, and never for pull_request events. Replace `github.head_ref == 'next'` with a check on `github.ref == 'refs/heads/next'` and `github.event_name != 'pull_request'`. Also add `next` to the `push.branches` list at the top of the workflow so pushes to next actually trigger CI and deployment.

Apply this code change:

    if: ${{ github.event_name != 'pull_request' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/next') }}

Not useful? Reply @miracodeai reject to dismiss this suggestion.

arthurfiorette and others added 2 commits November 15, 2026 23:02
Supersedes the open dependabot PRs. Also applies prettier 3.10 formatting.
Co-authored-by: arthurfiorette <47537704+arthurfiorette@users.noreply.github.com>

@mira-arthur mira-arthur Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira Review Summary

This PR has known vulnerabilities flagged in the catalog dependencies: vitest in packages/html/package.json (blocker), nitro in packages/nitro-html-plugin/package.json (blocker), h3 in packages/h3-html-plugin/package.json (blocker), and express in packages/express-html-plugin/package.json (blocker), with a lower-severity warning for fastify in packages/fastify-html-plugin/package.json. The four blockers should be resolved before merging, and the fastify warning should be reviewed.

"test:only": "tsc; node --no-deprecation --test-only --test dist/test"
"build": "tsgo -p tsconfig.build.json",
"prepack": "node ./scripts/copy-skills.mjs",
"test": "vitest --coverage --typecheck --run",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in vitest@catalog:

OSV.dev reports 2 known vulnerabilities affecting vitest@catalog:, introduced by this PR:

  • GHSA-5xrq-8626-4rwp critical: When Vitest UI server is listening, arbitrary file can be read and executed — fixed in 4.1.0, 3.2.6
  • GHSA-9crc-q9x8-hgqq critical: Vitest allows Remote Code Execution when accessing a malicious website while Vitest API server is listening — fixed in 1.6.1, 2.1.9, 3.0.5

Upgrade to 4.1.0, 3.2.6 or later.


Prompt for AI Agents
In packages/html/package.json, upgrade the dependency vitest from catalog: to a non-vulnerable version (1.6.1, 2.1.9, 3.0.5, 3.2.6, 4.1.0). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,62 @@
{
"name": "@kitajs/nitro-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in nitro@catalog:

OSV.dev reports 2 known vulnerabilities affecting nitro@catalog:, introduced by this PR:

  • GHSA-5w89-w975-hf9q moderate: Nitro has a proxy scope bypass via percent-encoded path traversal in routeRules — fixed in 3.0.260429-beta, 2.13.4
  • GHSA-9phm-9p8f-hw5m moderate: Nitro has an Open Redirect via Protocol-Relative URL Bypass in Wildcard Route Rules — fixed in 3.0.260429-beta, 2.13.4

Upgrade to 3.0.260429-beta, 2.13.4 or later.


Prompt for AI Agents
In packages/nitro-html-plugin/package.json, upgrade the dependency nitro from catalog: to a non-vulnerable version (2.13.4, 3.0.260429-beta). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,55 @@
{
"name": "@kitajs/h3-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in h3@catalog:

OSV.dev reports 5 known vulnerabilities affecting h3@catalog:, introduced by this PR:

  • GHSA-22cc-p3c6-wpvm high: h3 has a Server-Sent Events Injection via Unsanitized Newlines in Event Stream Fields — fixed in 2.0.1-rc.15, 1.15.6
  • GHSA-4hxc-9384-m385 moderate: h3: SSE Event Injection via Unsanitized Carriage Return (\r) in EventStream Data and Comment Fields (Bypass of CVE Fix) — fixed in 2.0.1-rc.17, 1.15.9
  • GHSA-72gr-qfp7-vwhw moderate: h3: Double Decoding in serveStatic Bypasses resolveDotSegments Path Traversal Protection via %252e%252e — fixed in 1.15.9

…and 2 more — see the OSV links above.

Upgrade to 2.0.1-rc.15, 1.15.6 or later.


Prompt for AI Agents
In packages/h3-html-plugin/package.json, upgrade the dependency h3 from catalog: to a non-vulnerable version (1.15.5, 1.15.6, 1.15.9, 2.0.1-rc.15, 2.0.1-rc.17). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

@@ -0,0 +1,51 @@
{
"name": "@kitajs/express-html-plugin",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
🛑 Blocker — must fix before merge

Known vulnerabilities in express@catalog:

OSV.dev reports 4 known vulnerabilities affecting express@catalog:, introduced by this PR:

  • GHSA-cm5g-3pgc-8rg4 moderate: Express ressource injection — fixed in 4.0.0-rc1
  • GHSA-gpvr-g6gh-9mc2 moderate: No Charset in Content-Type Header in express — fixed in 3.11.0, 4.5.0
  • GHSA-qw6h-vgh9-j6wx low: express vulnerable to XSS via response.redirect() — fixed in 4.20.0, 5.0.0

…and 1 more — see the OSV links above.

Upgrade to 4.0.0-rc1 or later.


Prompt for AI Agents
In packages/express-html-plugin/package.json, upgrade the dependency express from catalog: to a non-vulnerable version (3.11.0, 4.0.0-rc1, 4.19.2, 4.20.0, 4.5.0, 5.0.0, 5.0.0-beta.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

},
"dependencies": {
"fastify-plugin": "^5.0.1"
"fastify-plugin": "catalog:"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security issue
⚠️ Warning

Known vulnerabilities in fastify@catalog:

OSV.dev reports 10 known vulnerabilities affecting fastify@catalog:, introduced by this PR:

  • GHSA-444r-cwp2-x5xf moderate: fastify: request.protocol and request.host Spoofable via X-Forwarded-Proto/Host from Untrusted Connections — fixed in 5.8.3
  • GHSA-4mh8-r7rc-xpvc moderate: fastify vulnerable to Denial of Service via unhandled exception on HTTP/2 trailer responses — fixed in 5.12.5
  • GHSA-667r-xxjv-c9mm high: fastify vulnerable to request body replacement via an async validation result collision — fixed in 5.12.2

…and 7 more — see the OSV links above.

Upgrade to 5.8.3 or later.


Prompt for AI Agents
In packages/fastify-html-plugin/package.json, upgrade the dependency fastify from catalog: to a non-vulnerable version (0.38.0, 2.15.1, 5.12.1, 5.12.2, 5.12.5, 5.7.2, 5.7.3, 5.8.3). Update any associated lockfile entries.

Not useful? Reply @miracodeai reject to dismiss this suggestion.

This branch had an error being deployed

1 failed and 1 active deployments
github-pages — 1ff1e570 Deployed Nov 16, 2026 by arthurfiorette via Deploy Docs #2498
NPM Registry — 1ff1e570 Deployed Nov 16, 2026 by arthurfiorette via release #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants