Repository navigation
fix: keep pagination query defaults outside Annotated metadata - #732
Merged
nuclearcat merged 1 commit intoNov 3, 2026
Merged
Conversation
FastAPI 0.162 rejects defaults embedded in Query metadata when fastapi-pagination registers its parameter dependency, preventing the API from importing at add_pagination(app). Define limit and offset with Annotated Query constraints and separate defaults. Override the inherited offset as well, preserving the default page size, offset, and unlimited maximum page size. Add regression coverage for pagination registration, defaults, offsets, large pages, invalid query parameters, and OpenAPI generation. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FastAPI 0.162 rejects defaults embedded in Query metadata when fastapi-pagination registers its parameter dependency, preventing the API from importing at add_pagination(app).
Define limit and offset with Annotated Query constraints and separate defaults. Override the inherited offset as well, preserving the default page size, offset, and unlimited maximum page size.
Add regression coverage for pagination registration, defaults, offsets, large pages, invalid query parameters, and OpenAPI generation.