Repository navigation
[Automated] Draft docs (kagent): adk/mcp: defer tool discovery until invocation - #732
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…invocation Signed-off-by: GitHub Action <action@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target's own content scan fails where the base build passed (docs-theme-extras
markdown-leaks/built-html-integrity):kagent-dev/kagent#3560 — adk/mcp: defer tool discovery until invocation
Docs versions:
mainNo code-path rule covers 3 touched file(s). The planner could route these only by identifier search, so the candidate pages may miss what they changed, including in the other mode:
go/adk/examples/oneshot/main.gogo/adk/pkg/agent/agent.gogo/adk/pkg/agent/mcp_apps.goWhat changes for users: Agents on the kagent harness no longer wait for MCP tool discovery during startup, readiness, or Session resume. If one MCP server's catalog fails during an A2A execution, that server's tools are omitted for the execution, other MCP servers can still supply tools, and the next execution retries the omitted server.
What the docs now say: The About tools page now explains runtime MCP discovery, filtered cached catalogs, retry scope, and the separation from controller-side discovery. The caller token passthrough section now says a request with no bearer token omits the server's tools for that execution.
How
kagent-3560was draftedPlan, and what changed it
skills-and-mcp/about-tools.mdalready owns MCP binding behavior and carried a stale token-passthrough failure sentence; the target page and the code diff showed the correction.skills-and-mcp/about-tools.mdwith a runtime discovery subsection and corrected the token-passthrough sentence.Why a documentation change is necessary
The release note says MCP discovery no longer delays startup or resume and caches filtered tools safely. the code diff shows that the kagent runtime now discovers MCP tools during invocation preparation, filters the catalog before the model sees it, omits a failed toolset for the current A2A execution, and retries on a later execution. The About tools page documents MCP bindings and previously said a missing caller token made the MCP request fail, so readers would expect a different runtime behavior than the one in the diff.
How to verify this change
go test ./go/adk/pkg/mcp -run 'TestCreateToolsetsDoesNotContactSlowServers|TestFailedClassificationIsOmittedUntilNextRun|TestSDKCachePreservesFilteredToolsAndAppMetadata'.go test ./go/adk/pkg/a2a -run TestKAgentExecutorScopesMCPDiscoveryFailuresandgo test ./go/adk/pkg/a2a/server -run TestReadinessDoesNotWaitForMCPDiscovery.tools/listfails, then invoke the Agent twice. The first execution should expose only the healthy server's tools, and a later execution should retry the previously omitted server.Proposed release note
No
proposed-release-note.mdwritten becausemarkers.notes_placeableis false. Text for reviewer use: MCP discovery no longer delays startup or resume and caches filtered tools safely.Files in this pull request
docs-site/content/kagent/main/skills-and-mcp/about-tools.mdHow the pages were chosen (triage report)
Feature clusters
Kept apart on purpose. Merging wrongly produces a guide that documents two things and explains neither, so these are reported for a person to merge rather than grouped automatically:
docs-site/content/kagent/main/get-started/your-first-mcp-tool.mdas a candidate, but for one of them it is one page among more than 3, so they are kept apart; merge them if both drafts do land thereDraft a documentation change
kagent-dev/kagent#3560 — adk/mcp: defer tool discovery until invocation
kagent-dev/websitego/adk/examples/oneshot/main.gogo/adk/pkg/agent/agent.gogo/adk/pkg/agent/mcp_apps.goDraft branch:
pr-tracker-draft-kagent-3560