Skip to content

feat(lirr): add live Long Island Rail Road coverage - #23

Merged
joncrangle merged 1 commit into
mainfrom
feat/lirr-transit
Nov 13, 2026
Merged

joncrangle merged 1 commit into
mainfrom
feat/lirr-transit

Conversation

@joncrangle

Copy link
Copy Markdown
Owner

Summary

Closes #12. Adds Long Island Rail Road as an experimental rail agency, with live departures across the seeded network and an original eight-line, 33-station schematic.

LIRR manifest + schematic → shared catalog
                         → 13 routes / 126 geographic stations
                         → NYC subway, bus and Penn Station interchanges

The shared station source now uses each rail trip's seeded destination before a simplified map endpoint. Rail-only seeding also keeps undrawn served stations in the geographic index, so their departure destinations and advisory names remain readable without creating map navigation targets.

Evidence

  • Before: LIRR was absent. Vehicle descriptors without route/direction IDs disappeared without the static join. Simplified sequences could label through trains as terminating at Jamaica; undrawn advisory stops appeared as numeric IDs.
  • After: the module uses the existing static-trip join. Fresh capture on 2026-11-13 around 16:36 UTC returned 64 positions, 29 recent and 35 stale by the 180-second threshold, and 914 future predictions. Corrected Jamaica boards on both the local Worker and self-hosted production server returned 19 rows with distinct destinations, including short turns.
  • All 4,526 unit tests and 107 integration tests pass, including fictional regressions for per-trip rail destinations and undrawn station seeding. Formatting, lint, typecheck, production build, agency validation, documentation links, attribution and alert-identity asset checks pass.
  • Both final independent Terra reviews report no actionable findings. The first spec review's destination and undrawn-stop findings are fixed.
  • SQLite and local D1 are seeded. All 126 seeded stops are inside bounds. Auditing 146,304 existing regional stop points found zero Automatic selection changes.
  • A second interchange generation reports zero changed rows, no walking fallbacks and no NYC/LIRR placement conflicts. The 149 reported conflicts are pre-existing on other maps. Penn's bus badge column moved 20 units down to accommodate LIRR.
  • Desktop and mobile browser checks covered the original branch drawing, station cards, full/compact/hidden transfer badges and Grand Central's persistent walking node. The walking node opens the actual subway card and its badge switches networks. Both app runtimes render a healthy LIRR alert status with four current and eight upcoming notices; REST snapshots report live with 13 decoded alerts. Forced HTTP 503 reads fail on both hosting-target paths instead of reporting an all-clear.

Sources and scope

Reverified on 2026-11-13, initially around 16:08 UTC and again during acceptance checks:

  • Static GTFS: unauthenticated HTTP 200; feed GO203_26, 13 routes, 127 source stop rows and 1,871 trips, calendar dates 2026-11-10 through 2027-02-28. The seed has 126 served stops. All 13 branch IDs remain in the route catalog; branch names replace internal numeric IDs as public route labels.
  • Trips and vehicles: unauthenticated protobuf, with static-compatible trip IDs. tripDirectionSource: static resolves the missing vehicle descriptor identities. Published timestamps remain intact.
  • Railroad advisory JSON reconciled directly with all five current planned notices on the browser-rendered LIRR advisories page. Stop, route, direction and active-period scope remain published scope.
  • Rider references: TrainTime and the MTA railroads map, copyright 2025 edition. The schematic uses original geometry and public branch colors; representative trunks do not assert that every train runs their full length.
  • City preset coordinates come from this static feed: Penn 237, Grand Central 349, Jamaica 102 and Atlantic Terminal 241.
  • Registered transfers include Penn's national partners and NYC subway/bus connections. Grand Central Madison, East New York and Nostrand Avenue confirm facility identities and subway connections. East New York retains separate Atlantic Av and Broadway Junction boarding identities. Hillside Facility is excluded as an employee facility. FlixBus Hempstead uses roadside 168 Jackson St; it is excluded from the LIRR hub because an operator-documented rail walk was not found. Unregistered partners have no placeholder endpoints.
  • Attribution credits MTA and its published developer terms. Direct access to the terms page returned 403; the module records the terms as a best-effort statement.

Merge Danger

Door: Two-way. Module and relationship data can be reverted. Deployment requires the normal initial remote LIRR seed into DB_TRANSIT; this branch has only seeded local databases.

Blast Radius: Rail. Shared changes affect rail station destination labels and future rail-only station-index generation. Other agencies' generated station artifacts are unchanged.

@joncrangle
joncrangle marked this pull request as ready for review November 13, 2026 17:02
@joncrangle
joncrangle merged commit 947e8a7 into main Nov 13, 2026
2 checks passed
@joncrangle
joncrangle deleted the feat/lirr-transit branch November 13, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Long Island Rail Road as an experimental rail agency

1 participant