Repository navigation
feat(agencies): add New York City transit coverage - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add experimental NYC coverage for MTA Subway and Staten Island Railway, plus NYCT and MTA Bus Company buses. The full seeded network remains available beyond the simplified maps.
Core now supports exact feed-stop aliases, declared protobuf trip-direction extensions, and scalar JSON alert extensions. JSON trip selectors retain trip scope. NYC opts into strict interchange identity matching, preserving a facility's own boarding stops instead of relabelling unrelated nearby kerbs.
Closes #10. Closes #11.
Evidence
After: Both agencies pass
agency:check. Live cards show Grand Central services, SIR departures toward Tottenville, both bus directions, and distinct Penn 7th Avenue and 8th Avenue services.After: Fictional regression fixtures cover facility membership, exact aliases, direction extensions, extension classification, trip-only, route-plus-trip and mixed alert selectors. Penn inputs identify its real facilities and boarding stops. Undocumented FlixBus roadside walks are excluded; terminal connections remain.
livealert snapshots: 216 subway/SIR and 246 bus notices in the final capture. Forced upstream 503s produced failures rather than a live empty board. Local Vite/Worker UI displayed fresh snapshots and departures.Sources: MTA developer portal, Bus Time, subway map, ©2026, Manhattan bus map, undated asset retrieved 2026-11-13, current borough GTFS feeds, and Port Authority connections. Schematics are original drawings of route and stop facts.
The public advisories page returned 403 from this machine, including in Chrome, so a direct current page-to-feed comparison was unavailable. The integration uses the JSON channel confirmed by MTA's Data and APIs product manager to contain the website's planned changes, preserving its categories and published periods. This is the limit of the page reconciliation evidence, not a claim that today's page was inspected successfully.
Merge Danger
Door: two-way
Blast Radius: transit
Shared decoder and offline interchange-generation changes can affect other agencies using those formats. Existing data remains intact; regenerated NYC and affected national relationships are included.
Both SQLite and local D1 were seeded. Production has not been seeded or deployed. Before rollout, run the manual initial seed for
mta-subway,mta-businto the sharedDB_TRANSITbinding. Subway GPS positions are unavailable upstream; live departures work without fabricated positions. Bus feeds currently work without credentials despite older Bus Time documentation describing a key requirement.