Skip to content

Updated dependencies - #71

Closed
CarmeloBeeapp wants to merge 1 commit into
itsarvinddev:masterfrom
CarmeloBeeapp:master
Closed

CarmeloBeeapp wants to merge 1 commit into
itsarvinddev:masterfrom
CarmeloBeeapp:master

Conversation

@CarmeloBeeapp

Copy link
Copy Markdown

Updated dependencies and fixed compatibility with new version of retrofit and google_maps_apis

Fix issue: 68

@kilo-code-bot

kilo-code-bot Bot commented Apr 14, 2026

Copy link
Copy Markdown

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

itsarvinddev added a commit that referenced this pull request Sep 9, 2026
…uild

The first CI run failed four ways. Three were real; all three were things the
workflow existed to catch.

1. `channel: 3.38.0` — subosito/flutter-action's `channel` input only accepts
   stable/beta/master, so pinning the floor failed with "Unable to determine
   Flutter version for channel: 3.38.0". An exact release goes in
   `flutter-version`. The matrix is now an explicit `include` with an `id`, both
   because it reads better in the checks list and because `matrix.flutter-version`
   would have been parsed as subtraction in an Actions expression.

2. pana scored 150/160 on CI against 160/160 locally, losing the whole
   "example and screenshots" section to twelve "No such file or directory"
   errors. The screenshots are committed and are not LFS pointers -- pana shells
   out to ImageMagick and cwebp to generate thumbnails, and neither is on the
   ubuntu runner. Installed in that job.

3. The example's Android build failed on "You are applying Flutter's
   app_plugin_loader Gradle plugin imperatively using the apply script method,
   which is not possible anymore." The scaffold dated from 2022: Gradle 7.4,
   AGP 7.1.2, Kotlin 1.6.10, Groovy DSL, imperative plugin loader. Regenerated
   from the current Flutter template -- Kotlin DSL, declarative `plugins` block,
   Gradle 9.3.1, Java 17 -- keeping the API key meta-data and location
   permissions. Also dropped the legacy `package=` attribute from all three
   manifests (the namespace now lives in build.gradle.kts) and adopted the
   PROCESS_TEXT `queries` block the current template ships.

   `flutter build apk --debug` now succeeds locally.

The fourth failure is the third-party Kilo Code Review bot, which also reports
failure on the pre-existing #71 and #72.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
itsarvinddev added a commit that referenced this pull request Sep 12, 2026
…uild

The first CI run failed four ways. Three were real; all three were things the
workflow existed to catch.

1. `channel: 3.38.0` — subosito/flutter-action's `channel` input only accepts
   stable/beta/master, so pinning the floor failed with "Unable to determine
   Flutter version for channel: 3.38.0". An exact release goes in
   `flutter-version`. The matrix is now an explicit `include` with an `id`, both
   because it reads better in the checks list and because `matrix.flutter-version`
   would have been parsed as subtraction in an Actions expression.

2. pana scored 150/160 on CI against 160/160 locally, losing the whole
   "example and screenshots" section to twelve "No such file or directory"
   errors. The screenshots are committed and are not LFS pointers -- pana shells
   out to ImageMagick and cwebp to generate thumbnails, and neither is on the
   ubuntu runner. Installed in that job.

3. The example's Android build failed on "You are applying Flutter's
   app_plugin_loader Gradle plugin imperatively using the apply script method,
   which is not possible anymore." The scaffold dated from 2022: Gradle 7.4,
   AGP 7.1.2, Kotlin 1.6.10, Groovy DSL, imperative plugin loader. Regenerated
   from the current Flutter template -- Kotlin DSL, declarative `plugins` block,
   Gradle 9.3.1, Java 17 -- keeping the API key meta-data and location
   permissions. Also dropped the legacy `package=` attribute from all three
   manifests (the namespace now lives in build.gradle.kts) and adopted the
   PROCESS_TEXT `queries` block the current template ships.

   `flutter build apk --debug` now succeeds locally.

The fourth failure is the third-party Kilo Code Review bot, which also reports
failure on the pre-existing #71 and #72.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@itsarvinddev

Copy link
Copy Markdown
Owner

Thank you for this, @CarmeloBeeapp — the diagnosis here was the key that unlocked #68, and it is the basis of the fix in #73.

You were right that google_maps_apis 5.x is the real answer. For anyone finding this later, the precise mechanism: 4.0.0's CustomParseErrorLogger.logError takes three positional arguments, while retrofit ≥ 4.9.0 widened ParseErrorLogger.logError to four — so any app whose graph pulled a newer retrofit failed to compile. 5.0.0 fixed the signature.

What #73 took from this PR:

  • google_maps_apis to 5.x (pinned at >=5.1.0 — 5.0.0 still used the old copyWith generator, where passing an explicit null nullifies a field, and 5.1.0 also carries an upstream ResponseStatus parsing fix)
  • flutter_typeahead 6, dio, http, cupertino_icons and the lints bumps
  • going further: retrofit and web are removed entirely. Neither was imported anywhere in lib/, and it was the retrofit: ">=4.7.3 <4.9.0" pin that made google_maps_apis version Exception #68 painful in the first place

Two hunks I did not take, with reasons rather than silence:

google_maps_flutter: ^2.17.0 — 2.15.0+ requires Dart 3.10 / Flutter 3.38, while the pubspec still declared flutter: ">=3.27.0". That combination is unresolvable for everyone between those versions. #73 keeps a range (>=2.13.1 <3.0.0) instead, so pub picks 2.18.0 on new SDKs and an older 2.x below that, and raises the declared floor honestly.

Commenting out hideWithKeyboard — you were right that typeahead 6 removed it, but silently dropping the call turns a documented SearchConfig option into a no-op. It is now @Deprecated pointing at hideOnUnfocus, which is the documented replacement, and constrainWidth (new in typeahead 6) is exposed.

Closing as superseded by #73. Thank you for doing the version archaeology — that is the tedious part, and you did it.

itsarvinddev added a commit that referenced this pull request Sep 12, 2026
Closes #70, #68, #65, #14. Supersedes #72, #71, #67, #66.

pub.dev score 120/160 -> 160/160. Tests 0 -> 83, green on Flutter 3.38.1 (the declared floor) and 3.47.2.
@itsarvinddev

Copy link
Copy Markdown
Owner

#73 is merged and released as 4.0.0, carrying your change with credit — see the detailed comment above. Closing as superseded, not rejected. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants