Repository navigation
Stop composer install when a patch does not apply - #411
Open
turegjorup wants to merge 1 commit into
Open
turegjorup wants to merge 1 commit into
turegjorup wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop
composer installwhen a composer patch does not apply.Changes
"composer-exit-on-patch-failure": truetoextraincomposer.json.content-hashincomposer.lock. No package changes.Why
Without this setting, cweagans/composer-patches 1.x writes "Could not apply patch! Skipping" and continues. The install, CI and the deploy succeed, and the site runs without the fix from the patch. On doner-din-stemme a core patch did not apply for some time, and nobody saw it.
With this setting, a failed patch stops
composer install. CI and the deploy then fail, and the problem is visible.Checked locally:
composer reinstallof all patched packages (drupal/core drupal/entity_print drupal/flag drupal/masquerade drupal/openid_connect drupal/toc_api) applies all 8 patches with the setting on.