Repository navigation
WO20: reverse-mode golden gate in the additivity workflow (#286) - #297
Merged
Merged
Conversation
Each runtime job gains a reverse step alongside its forward step: rs replays tests/golden_reverse_capture.rs, ts test/golden-isc-reverse.test.ts, ruby tools/isc_wf1_golden_gate.rb --reverse, py tests/test_golden_reverse.py — all against the RS-captured reverse golden (interscript-rs tests/golden/isc-reverse.jsonl: 10,024 rows over 313 maps, captured once by iscrs capture --reverse; maps whose reverse still diverges across the runtimes are excluded via the rs-side manifest tests/golden/reverse-divergent-maps.txt, shrink-to-zero). The forward golden steps are untouched. Merge order: the three runtime branches (wo20-reverse-gate-rs, wo20-reverse-gate-ruby, wo20-reverse-gate-ts) must land before (or with) this change — until then the reverse files are absent on the rs main checkout and every reverse step no-ops (skip-on-missing is uniform: rs/ts/py skip in-test, the ruby tool exits 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WO20 (#286): wire the reverse-mode golden gate into maps-CI's additivity workflow. Reverse mode exists in all four runtimes (rs reference capture, ruby pin, ts/py compiled-IR ports) but had no cross-runtime golden; the rs branch (interscript/interscript-rs#32) captured it once —
tests/golden/isc-reverse.jsonl, 10,024 rows over 313 maps (the reversed documents' own embedded tests, i.e. every row's src is a forward expected output) — and this workflow change replays it in every runtime job alongside the forward steps:tests/golden_capture.rstests/golden_reverse_capture.rstest/golden-isc-wf0.test.tstest/golden-isc-reverse.test.tstools/isc_wf1_golden_gate.rbtools/isc_wf1_golden_gate.rb --reversetests/test_golden_capture.pytests/test_golden_reverse.pytests/golden/reverse-divergent-maps.txt, which documents the divergence families and shrinks to zero as the engines converge.isc-wf0.jsonl, 13,745 rows — zero-delta re-verified).Merge order
The three runtime branches must land before (or with) this change:
interscript/interscript-rs#32(capture + golden),interscript/interscript-ruby#865(ruby + py replay), and the ts branch forwo20-reverse-gate-ts. Until then the reverse files are absent on the checked-out mains and every reverse step no-ops — skip-on-missing is uniform (rs/ts/py skip in-test; the ruby gate tool exits 0 with a notice).Test plan