Repository navigation
feat(WO20): exhaustive per-row tests for eight thin DIN 1460-2 maps (coverage depth, batch 2) - #288
Merged
Merged
Conversation
…coverage depth) Rows from tools/din1460-2-table.json (PR #242 mechanical extraction of DIN 1460-2:2011-10 Tabelle 1), re-verified cell-by-cell against the printed grid rectangles via pymupdf find_tables, generated into embedded tests with scripts/gen-row-tests.mjs. No map rules changed. 265 rows generated, all passing end-to-end; 6 source-anchored findings recorded: four cells where the extraction dropped the combining cedilla (ķ/ņ flattened to k/n in ab/az/ba) and two broken к̢ -> empty rules in atv/az from a parenthesized-cell fragment.
ronaldtse
added a commit
that referenced
this pull request
Nov 16, 2026
Three batches from held sources (maps #287/#288/#289): eight odni ICS-630 maps, eight thinnest DIN 1460-2 maps, six small ALA-LC tables - 906 exhaustive per-row tests, all verified end-to-end; 48 source-anchored findings recorded for follow-up fixes. Golden refreshed additively (rs #30): 13,745 rows, zero lost/changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WO20 coverage-depth, batch 2 (#283): the eight thinnest DIN 1460-2:2011 maps, deepened from the held source PDF (
interscript-private-references/din/din-1460-2.pdf) viascripts/gen-row-tests.mjs. The rows come from the durable mechanical extractiontools/din1460-2-table.json(maps PR #242 provenance), re-verified cell-by-cell against the printed grid rectangles (pymupdffind_tablesre-extraction) — that reconciliation surfaced six cells where the original extraction had dropped the combining cedilla (U+0327) or fragmented a parenthesized cell. No map rules changed; 6 source-anchored findings recorded, never forced green. 52 more din-1460-2 maps remain at 4 tests each and can follow the identical mechanical pattern.Per-map counts (transcribed = generated; every generated test passes)
DIN's parenthesized cells (optional-value notation) are transcribed without the typographic parentheses, documented per artifact; the pos-34 PUA glyph (U+E553) is the one PR #242 visually identified as j-acute, transcribed as j́.
Findings (source-anchored; maps untouched this round)
sub "к̢" ""(empty target) — the artifact had recorded a stray(from the parenthesized "(ķ)" cell, so printed-key input к̢ is silently deleted by the map; the printed cell reads (ķ) → ķ.Gates
iscrs test-all --maps maps(branch corpus): 11,936 passed, 0 failed (the eight maps: 297 tests)iscrs capture --root mapsvs interscript-rstests/golden/isc-wf0.jsonl): 0 lost, 0 changed; +689 uncaptured rows — +233 din (this batch's rows minus rows already present), +450 pre-existing from the feat(WO17): exhaustive per-row test generator; alalc-vai 240-row demonstration #272/feat(WO19): exhaustive per-row tests for alalc-hye/zgh/chr (conformance depth) #281 vai/hye/zgh/chr generated rows, +6 pre-existing singles on main. The rs golden is not touched here (maps-side PRs only per the WO20: corpus coverage audit + conformance-depth batches from held sources #283 coordination); a single rs golden-recapture PR will cover all WO20 batches.iscrs transliterate; cell-level reconciliation of all 8 languages' printed grid rectangles against the artifact values (271 artifact cells re-extracted, 6 mismatches found and handled).Test plan
iscrs test-allgreen on the branch corpusscripts/row-sources/*.jsonnote