Repository navigation
WO19 G6: pin the capital-U escape rows; document the rs grammar extensions - #279
Merged
Merged
Conversation
…sions Item 4: embedded test rows for the six bel/rus maps carrying capital-U escapes. gki-bel/mvd-bel/odni-bel spell the true "\U040E" escape (decodes to Ў; the generated ts/py parsers used to carry the literal "U040E" text and the row never fired) - pinned with "Ў" rows verified on all four runtimes (Ŭ/W/W). alalc-bel/bgnpcgn-bel/mvd-rus spell the row with a DOUBLED backslash - literal backslash + raw U040E text, not the escape - pinned with a "Ў" -> "Ў" dormancy row (the corrupted row must not fire on Ў; ruby and rs agree). No transliteration output changes: the rs golden capture replays 12,337/12,337 rows byte-identically. Item 6: spec section 9 enumerates the four canonical-adopted rs grammar extensions (ruleset_decl, use_directive, languages_decl, the when guard) with exact semantics. B.2 of the parity README gets a G6 errata: the six fn-literal keyword rows are resolved (ruby's table adopted everywhere) and the ruleset row was already stale (rs joined ruleset in the G7 round).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Item 4 — \U escape pins. Embedded test rows for the six bel/rus maps that carry capital-
\Uescapes:"\U040E"(true escape)"Ў" -> "Ŭ""\U040E"(true escape)"Ў" -> "W""\U040E"(true escape)"Ў" -> "W""\\U040E"(doubled backslash)"Ў" -> "Ў"(dormancy)"\\U040E"(doubled backslash)"Ў" -> "Ў"(dormancy)"\\U040E"(doubled backslash)"Ў" -> "Ў"(dormancy)The three true-escape rows are the ones the generated ts/py parsers used to get wrong (from-value carried as the literal text "U040E"; the row never fired) — the pins make the embedded-test gates catch that regression in every runtime. Verified on all four runtimes (rs/ruby/ts/py produce Ŭ/W/W). The three doubled-backslash rows are literal-backslash + raw text — NOT the escape — so they must not fire on Ў; the dormancy pins record exactly that (verified rs = ruby = ts = py).
Deviations from the brief, with evidence:
\U040E, ruby effectively matches "U040E" — probed directly), so no test row can pass both. Pinned the dormancy instead.Item 6 — spec section.
docs/isc-wf-1.md§9 enumerates the four canonical-adopted rs grammar extensions (ruleset_decl, use_directive, languages_decl, the when guard) with exact semantics.docs/parity/README.mdB.2 gets a G6 errata (fn-literal keyword rows resolved everywhere; the ruleset-omission note was already stale — rs joinedrulesetin the G7 round).Gates
iscrs testover the six maps: 172 passed, 0 failedtools/isc_wf1_golden_gate.rb): 12,337/12,337, exit 0