Repository navigation
fix(isc): a ruleset declared twice is a load error (G7, py canon) - #138
Merged
Merged
Conversation
keep-first silently hid map bugs, and first-`find` lookup made the executed body declaration-order dependent. expandDocument now rejects duplicate ruleset names with a named IscLoadError, matching rs #19's builder check and py's parse rejection; ruby keeps first (its half is separate). Every document passes through expandDocument at load - deps included - so a dependent's duplicate cannot slip through. TDD: wf1 test red (loaded, executed the second body) -> green; isc suite 135/135.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WO18 audit gap G7 - the ts half (rs landed in interscript-rs#19, py rejects at parse).
ruleset adeclared twice: ts silently kept the FIRST definition andfind()lookup made the executed body declaration-order dependent.expandDocumentnow throws a namedIscLoadError("declared more than once in "); every document passes through it at load, dependencies included. Audit probetst-rscyclecontext: with in-blockusethe old merge could pull content from BOTH definitions.TDD: wf1 test red (loaded and executed the second body) then green; isc suite 135/135; lint + prettier clean.