Skip to content

fix(isc): use inside sequence/parallel blocks per spec 3.2 - #137

Merged
ronaldtse merged 3 commits into
mainfrom
wo18-g5-ts
Nov 14, 2026
Merged

ronaldtse merged 3 commits into
mainfrom
wo18-g5-ts

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

fix(isc): use inside sequence/parallel blocks per spec 3.2

The generated grammar's rule_line now accepts the use directive inside
sequence/parallel blocks (PG grammar regenerated from the canonical
.parg; sha pin bumped), and the converter/expansion layer implements
the rs-canonical semantics: a used ruleset's rules flatten into the
enclosing collection in position, an override block merges per-rule
(child-wins on exact from-equality), and a non-rule target (funcalls,
stage runs inside the used ruleset) is a named MapLogicError - non-rule
items cannot join a pass.

rs is the reference implementation and is unchanged. No corpus map
uses the constructs (428 maps parse unchanged); the probe shapes from
the parity audit (tst-use-inseq / use-in-parallel) pin the behavior.

Suite 378 -> 385 passed (+7 wf1 tests), parser-parity and conformance
gates green in CI.

The generated grammar's rule_line now accepts the use directive inside
sequence/parallel blocks (PG grammar regenerated from the canonical
.parg; sha pin bumped), and the converter/expansion layer implements
the rs-canonical semantics: a used ruleset's rules flatten into the
enclosing collection in position, an override block merges per-rule
(child-wins on exact from-equality), and a non-rule target (funcalls,
stage runs inside the used ruleset) is a named MapLogicError - non-rule
items cannot join a pass.

rs is the reference implementation and is unchanged. No corpus map
uses the constructs (428 maps parse unchanged); the probe shapes from
the parity audit (tst-use-inseq / use-in-parallel) pin the behavior.

Suite 378 -> 385 passed (+7 wf1 tests), parser-parity and conformance
gates green in CI.
G5 restructured block expansion into expandBlockRow, leaving the
expandItems inBlock flag with no caller passing it.
@ronaldtse
ronaldtse merged commit 42a8b36 into main Nov 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant