Repository navigation
fix(isc): use inside sequence/parallel blocks per spec 3.2 - #137
Merged
Merged
Conversation
The generated grammar's rule_line now accepts the use directive inside sequence/parallel blocks (PG grammar regenerated from the canonical .parg; sha pin bumped), and the converter/expansion layer implements the rs-canonical semantics: a used ruleset's rules flatten into the enclosing collection in position, an override block merges per-rule (child-wins on exact from-equality), and a non-rule target (funcalls, stage runs inside the used ruleset) is a named MapLogicError - non-rule items cannot join a pass. rs is the reference implementation and is unchanged. No corpus map uses the constructs (428 maps parse unchanged); the probe shapes from the parity audit (tst-use-inseq / use-in-parallel) pin the behavior. Suite 378 -> 385 passed (+7 wf1 tests), parser-parity and conformance gates green in CI.
G5 restructured block expansion into expandBlockRow, leaving the expandItems inBlock flag with no caller passing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(isc): use inside sequence/parallel blocks per spec 3.2
The generated grammar's rule_line now accepts the use directive inside
sequence/parallel blocks (PG grammar regenerated from the canonical
.parg; sha pin bumped), and the converter/expansion layer implements
the rs-canonical semantics: a used ruleset's rules flatten into the
enclosing collection in position, an override block merges per-rule
(child-wins on exact from-equality), and a non-rule target (funcalls,
stage runs inside the used ruleset) is a named MapLogicError - non-rule
items cannot join a pass.
rs is the reference implementation and is unchanged. No corpus map
uses the constructs (428 maps parse unchanged); the probe shapes from
the parity audit (tst-use-inseq / use-in-parallel) pin the behavior.
Suite 378 -> 385 passed (+7 wf1 tests), parser-parity and conformance
gates green in CI.