Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/interscript/isc/document_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,15 @@ def build
languages_arr.concat(Array(item[:languages]).map { |l| ident(l) })
elsif item[:ruleset]
# ISC-WF-1 W1: named ruleset declaration.
rulesets_arr << extract_ruleset(item)
rs = extract_ruleset(item)
# WO18 G7 (py canon): a duplicate declaration is a load
# error - keep-first hides map bugs and makes the executed
# body declaration-order dependent (rs #19, ts #138).
if rulesets_arr.any? { |existing| existing[:name] == rs[:name] }
raise Interscript::MapLogicError,
%(ruleset "#{rs[:name]}" declared more than once in #{@filename})
end
rulesets_arr << rs
elsif item[:stage]
stages_arr << extract_stage(item)
elsif item[:target]
Expand Down
10 changes: 10 additions & 0 deletions spec/interscript/isc/wf1_semantics_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ def interpreter_for(src)
end

describe "W1 expansion" do
# WO18 G7 (py canon): a duplicate ruleset declaration is a load
# error - keep-first hides map bugs and makes the executed body
# declaration-order dependent (rs #19, ts #138).
it "rejects a duplicate ruleset definition" do
src = 'system "T:g7:1" { ruleset a { sub "x" "1" } ruleset a { sub "x" "2" } stage main { use a } }'
expect { build_node_doc(src) }.to raise_error(
Interscript::MapLogicError, /ruleset "a" declared more than once/
)
end

let(:src) do
<<~ISC
system "T:e-L:Latn:1" {
Expand Down
Loading