Repository navigation
fix(py): update the un-bul api vector to the reissued 1977 rows - #851
Merged
Merged
Conversation
test_transliterate_known_vector asserted "nos Byaga BYAGA" - the yu/ya values of the superseding current system, predating the map's reissue (the 1977 system romanizes ya/JA as ja/Ja; the map's own embedded tests pin ju/ja/Ju). The bundled IR refresh (#846) surfaced the mismatch. Runtime output matches the map; the test data was stale. TDD: red on clean origin/main ("Bjaga" != "Byaga"), green after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_transliterate_known_vectorassertednos Byaga BYAGA- the yu/ya values of the superseding current system, written before the un-bul-Cyrl-Latn-1977 reissue changed ya rows to ja (the map's own embedded tests and reissue note pin ju/ja/Ju). The bundled IR refresh (#846) surfaced the mismatch: the runtime output already matches the map; the hardcoded vector was stale. Red on clean origin/main, green after the one-line vector update.