Skip to content

fix: Item::Alias#max_length — rs parity, the 33-row cross-runtime exemption retires (WO17) - #840

Merged
ronaldtse merged 1 commit into
mainfrom
fix/alias-max-length
Nov 11, 2026
Merged

ronaldtse merged 1 commit into
mainfrom
fix/alias-max-length

Conversation

@ronaldtse

Copy link
Copy Markdown
Contributor

Summary

Item::Alias#max_length raised NotImplementedError for any non-stdlib alias, so whole megaregexp passes errored: 33 golden rows across un-ara-Arab-Latn-1971/1972 and the odni-rus Arabic variants carried a standing cross-runtime exemption in every golden comparison.

The rs runtime — the golden source, at zero deltas — counts every alias as max_length 1 (rs Item::max_length: Prim/Alias => 1, 0 for none); resolving the expansion would need document context the sort site does not carry. The ruby runtime now mirrors that, one branch collapsed.

Verification (WO17 step 1)

  • Ruby golden gate: ruby -Ilib tools/isc_wf1_golden_gate.rb --parity → rows: 12337 ... delta vs golden (cross-runtime): 0 — was 33.
  • TDD: both new specs watched failing before the fix — the integration row through the megaregexp path (expected values pinned to the rs outputs for the same document, iscrs run recorded in the WO17 ledger) and the unit counts (any alias 1, none 0).
  • Full suite: 409 examples, 0 failures (SKIP_JS/SKIP_PYTHON); standardrb clean on changed files.
  • The WO80 capture-in-parallel pin (NoMethodError on max_length) is unaffected — different class, capture stays unsupported in parallel.

The deterministic parallel sort (megaregexp path) raised
NotImplementedError for any non-stdlib alias, erroring whole passes:
33 golden rows across un-ara-Arab-Latn-1971/1972 and the odni-rus
Arabic variants carried a standing cross-runtime exemption. The
rs runtime - the golden source, at zero deltas - counts every alias
as max_length 1 (rs Item::max_length: Prim/Alias => 1, 0 for none),
and alias resolution would need document context the sort site does
not carry. The ruby runtime now mirrors that.

Specs watched failing first: the pinned-to-rs integration row through
the megaregexp path, and the unit counts (any alias 1, none 0).
Verified: ruby golden gate parity 12,337 rows -> delta 0 (was 33);
full suite 409 examples 0 failures; the WO80 capture-in-parallel
NoMethodError pin is unaffected (different class, capture stays
unsupported in parallel).
@ronaldtse
ronaldtse merged commit fea44ab into main Nov 11, 2026
13 checks passed
@ronaldtse ronaldtse mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant